Summary

Stop automatically adding/remove conversations from the conversation manager

Review Request #3049 — Created March 26, 2024 and submitted March 26, 2024, 4:57 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This was done to mimic the old conversations API and shouldn't be needed going
forward. However, since we can't create conversations right now, we're probably
missing some edge cases here.

Also make sure to keep a reference around on the conversation while removing to avoid use after frees.

Testing Done

Trained with the turtles.

Commits

Summary	ID
Stop automatically adding/remove conversations from the conversation manager This was done to mimic the old conversations API and shouldn't be needed going forward. However, since we can't create conversations right now, we're probably missing some edge cases here.	f50d99576a76eb51e543b9da3bb799a4e63f257d

Change Summary:: Fix typo.
Description:: This was done to mimic the old conversations API and shouldn't be needed going
forward. However, since we can't create conversations right now, we're probably
missing some edge cases here.

~
Also make sure to keep a reference around on the account while removing to avoid use after frees.
~
Also make sure to keep a reference around on the conversation while removing to avoid use after frees.

Ship it!

```
Ship It!
```

Status:: Completed

		This was done to mimic the old conversations API and shouldn't be needed going
		forward. However, since we can't create conversations right now, we're probably
		missing some edge cases here.

~		Also make sure to keep a reference around on the account while removing to avoid use after frees.
	~	Also make sure to keep a reference around on the conversation while removing to avoid use after frees.