Summary

Add a doc check unit test to gplugin-gtk and fix the issues it found

Review Request #3040 — Created March 20, 2024 and submitted March 21, 2024, 12:11 a.m.

Information

Owner

grim

Repository

gplugin/gplugin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Add a doc check unit test to gplugin-gtk and fix the issues it found

Testing Done

Ran the unit tests

Commits

Summary	ID
Add a doc check unit test to gplugin-gtk and fix the issues it found	4bdfc9f62d976ba48b517c12dbd9af8e5aac45f3

Issues

Description	From	Last Updated
This should probably be consistent with the line in the doc generation above.	QuLogic	March 20, 2024, 11:56 p.m.
Does this need to depend on gplugin_gir[0] just as the doc target does?	QuLogic	March 21, 2024, 12:04 a.m.

Change Summary:

remove an extra new line

Commits:

	Summary	ID
	Add a doc check unit test to gplugin-gtk and fix the issues it found	14e6625f11be8ba130f75a65f769fb0eb51ed973
	Add a doc check unit test to gplugin-gtk and fix the issues it found	a5c52384dbb1c3496211fcc2e252d4551a6a98a1

Diff:

Revision 2 (+116 -2)

Show changes

	gplugin-gtk4/gplugin-gtk-version.h
	gplugin-gtk4/gplugin-gtk-view.c
	gplugin-gtk4/reference/gplugin-gtk4.toml.in
	gplugin-gtk4/reference/meson.build

gplugin-gtk4/reference/meson.build (Diff revision 2)

The issue has been resolved. Show all issues

This should probably be consistent with the line in the doc generation above.

grim March 20, 2024, 11:46 p.m.

ah yeah I did this in later review requests and didn't come back and get this one..

Change Summary:

use the global add include path version and fix indentation.

Commits:

	Summary	ID
	Add a doc check unit test to gplugin-gtk and fix the issues it found	a5c52384dbb1c3496211fcc2e252d4551a6a98a1
	Add a doc check unit test to gplugin-gtk and fix the issues it found	dc53ecaa6bb2eebfc9da17f1f2b72c45bc878b7f

Diff:

Revision 3 (+116 -2)

Show changes

	gplugin-gtk4/gplugin-gtk-version.h
	gplugin-gtk4/gplugin-gtk-view.c
	gplugin-gtk4/reference/gplugin-gtk4.toml.in
	gplugin-gtk4/reference/meson.build

gplugin-gtk4/reference/meson.build (Diff revisions 2 - 3)
The issue has been resolved. Show all issues
```
Does this need to depend on gplugin_gir[0] just as the doc target does?
```

Change Summary:

fix dependencies

Commits:

	Summary	ID
	Add a doc check unit test to gplugin-gtk and fix the issues it found	dc53ecaa6bb2eebfc9da17f1f2b72c45bc878b7f
	Add a doc check unit test to gplugin-gtk and fix the issues it found	4bdfc9f62d976ba48b517c12dbd9af8e5aac45f3

Diff:

Revision 4 (+116 -2)

Show changes

	gplugin-gtk4/gplugin-gtk-version.h
	gplugin-gtk4/gplugin-gtk-view.c
	gplugin-gtk4/reference/gplugin-gtk4.toml.in
	gplugin-gtk4/reference/meson.build

Ship it!

```
Ship It!
```

Status:: Completed