Summary

Fix the windows build for real this time

Review Request #3030 — Created March 16, 2024 and submitted March 16, 2024, 10:05 p.m.

Information

Owner

grim

Repository

gplugin/gplugin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description


Mark gplugin_introspection_introspect_plugin and

  gplugin_introspection_introspect_plugins as internal as this is a static

  library and that is how they should be marked.
Use G_MODULE_EXPORT to export the G_DEFINE_FINAL_TYPE for IntrospectableType.
Clean up the gplugin-introspection/tests/meson.build file bit as it's

   already shortcut in gplugin-introspection/meson.build.

Testing Done

Compiled from a clean build on Windows and Linux using ninja turtles on both.

Commits

Summary	ID
Fix the windows build for real this time * Mark gplugin_introspection_introspect_plugin and gplugin_introspection_introspect_plugins as internal as this is a static library and that is how they should be marked. * Use G_MODULE_EXPORT to export the G_DEFINE_FINAL_TYPE for IntrospectableType. * Clean up the gplugin-introspection/test/meson.build file bit as it's already shortcut in gplugin-introspection/meson.build.	bb102e9ca53f67339dfa76c16338424898420f3f

Summary

Fix the windows build for real this time

* Mark gplugin_introspection_introspect_plugin and gplugin_introspection_introspect_plugins as internal as this is a static library and that is how they should be marked. * Use G_MODULE_EXPORT to export the G_DEFINE_FINAL_TYPE for IntrospectableType. * Clean up the gplugin-introspection/test/meson.build file bit as it's already shortcut in gplugin-introspection/meson.build.

bb102e9ca53f67339dfa76c16338424898420f3f

Change Summary:: tested successfully on linux
Testing Done:: ~
Compiled from a clean build on Windows.
~
Compiled from a clean build on Windows and Linux using ninja turtles on both.
- Need to test on Linux yet.

Change Summary:: Fix a typo.
Description:: Mark gplugin_introspection_introspect_plugin and
gplugin_introspection_introspect_plugins as internal as this is a static
library and that is how they should be marked.

Use G_MODULE_EXPORT to export the G_DEFINE_FINAL_TYPE for IntrospectableType.
~
Clean up the gplugin-introspection/tesst/meson.build file bit as it's
already shortcut in gplugin-introspection/meson.build.
~
Clean up the gplugin-introspection/tests/meson.build file bit as it's
already shortcut in gplugin-introspection/meson.build.

Ship it!

```
Ship It!
```

Status:: Completed

~		Compiled from a clean build on Windows.
	~	Compiled from a clean build on Windows and Linux using `ninja turtles` on both.
-		Need to test on Linux yet.

		Mark gplugin_introspection_introspect_plugin and gplugin_introspection_introspect_plugins as internal as this is a static library and that is how they should be marked.
		Use G_MODULE_EXPORT to export the G_DEFINE_FINAL_TYPE for IntrospectableType.
~		Clean up the gplugin-introspection/tesst/meson.build file bit as it's already shortcut in gplugin-introspection/meson.build.
	~	Clean up the gplugin-introspection/tests/meson.build file bit as it's already shortcut in gplugin-introspection/meson.build.