Make sure we're capturing stderr when we're trapping subprocesses

Review Request #3021 — Created March 12, 2024 and discarded

Information

gplugin/gplugin
default

Reviewers

This didn't use to be necessary, but tests are being flaky without it.

Ran with the turtles, about to test on freebsd.

Summary ID
Make sure we're capturing stderr when we're trapping subprocesses
This didn't use to be necessary, but tests are being flaky without it.
9752bf8585eac483f0360dbca36137b1bc0ae1de
Description From Last Updated

The docs say: If this flag is given, the child process will inherit the parent's stderr. Otherwise, the child's stderr …

QuLogicQuLogic
QuLogic
  1. 
      
  2. gplugin/tests/test-auto-load.c (Diff revision 1)
     
     
     
     
    Show all issues

    The docs say:

    If this flag is given, the child process will inherit the parent's stderr. Otherwise, the child's stderr will not be visible, but it will be captured to allow later tests with g_test_trap_assert_stderr().

    And we are calling g_test_trap_assert_stderr after, so it seems like we shouldn't be passing this flag.

    1. You are right. I'm not sure how I confused myself with this stuff, but yeah it's wrong :)

  3. 
      
grim
Review request changed
Status:
Discarded