Summary

Create PurpleCreateConversationDetails

Review Request #3014 — Created March 8, 2024 and submitted March 19, 2024, 5:47 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17855

Depends On

Reviewers

Groups

pidgin

People

Description

This is the first step of letting protocols create the conversations for us.

Testing Done

Ran the unit tests and the turtles.

Commits

Summary	ID
Create PurpleCreateConversationDetails This is the first step of letting protocols create the conversations for us.	6bb1afb8e9ce6c0de039f0589f532edb2e9a26a8

Issues

Description	From	Last Updated
Minimum should be 0 for unlimited?	QuLogic	March 19, 2024, 5:29 a.m.
You could also swap the order here and use g_assert_finalize_object(store) since the details object should no longer own a ref …	QuLogic	March 19, 2024, 5:29 a.m.

libpurple/purplecreateconversationdetails.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Minimum should be 0 for unlimited?
```

libpurple/tests/test_create_conversation_details.c (Diff revision 1)

The issue has been resolved. Show all issues

You could also swap the order here and use g_assert_finalize_object(store) since the details object should no longer own a ref on it, and this function is the last ref.

Change Summary:

Rebase and address issues

Commits:

	Summary	ID
	Create PurpleCreateConversationDetails This is the first step of letting protocols create the conversations for us.	573ba2ff1a44b2d1c04396e7b98f7f0600d4af9f
	Create PurpleCreateConversationDetails This is the first step of letting protocols create the conversations for us.	6bb1afb8e9ce6c0de039f0589f532edb2e9a26a8

Diff:

Revision 2 (+832)

Show changes

	libpurple/meson.build
	libpurple/purplecreateconversationdetails.h
	libpurple/purplecreateconversationdetails.c
	libpurple/tests/meson.build
	libpurple/tests/test_create_conversation_details.c

Ship it!

```
Ship It!
```

Status:: Completed