grim got a fish trophy!

Summary

Fix the developer name and component id in our appdate metafile

Review Request #3003 — Created March 1, 2024 and submitted March 12, 2024, 2:26 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

I just updated my machine and the test started failing because we didn't have
the developer name setup properly. It was also throwing a pedantic warning
about the component id, so I made it all lower case as well.

I also set the tests to verbose so we can always see their output.

Testing Done

Kicked butt with the turtles.

Commits

Summary	ID
Fix the developer name and component id in our appdate metafile I just updated my machine and the test started failing because we didn't have the developer name setup properly. It was also throwing a pedantic warning about the component id, so I made it all lower case as well.	f2379714c468c30af7ac02dca5419aef63f336a5

Issues

Description	From	Last Updated
Not sure this needs to change (e.g., their example is org.mozilla.Firefox). The TLD must be lower case, but the application …	QuLogic	March 12, 2024, 2:24 a.m.

pidgin/data/im.pidgin.Pidgin3.metainfo.xml (Diff revision 1)

The issue has been resolved. Show all issues

Not sure this needs to change (e.g., their example is org.mozilla.Firefox). The TLD must be lower case, but the application name doesn't have to be. But this needs to match the application ID and now it doesn't. Most GNOME applications are not fully lowercase too.

grim March 5, 2024, 7:20 a.m.

Huh, didn't realize they were supposed to match. Fix coming in a moment.

Change Summary:

fix the id to match the application id

Commits:

	Summary	ID
	Fix the developer name and component id in our appdate metafile I just updated my machine and the test started failing because we didn't have the developer name setup properly. It was also throwing a pedantic warning about the component id, so I made it all lower case as well.	10d30b79fe29967d3ff137146c22fc49e14ddcfb
	Fix the developer name and component id in our appdate metafile I just updated my machine and the test started failing because we didn't have the developer name setup properly. It was also throwing a pedantic warning about the component id, so I made it all lower case as well.	f2379714c468c30af7ac02dca5419aef63f336a5

Diff:

Revision 2 (+10 -2)

Show changes

	pidgin/data/im.pidgin.Pidgin3.metainfo.xml
	pidgin/data/meson.build

Ship it!

```
Ship It!
```

Status:: Completed