Summary

Move the dependecy regex instance to the manager instance

Review Request #2985 — Created Feb. 28, 2024 and submitted Feb. 28, 2024, 6:59 p.m.

Information

Owner

grim

Repository

gplugin/gplugin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

We used to do this as a global to save a tiny amount of memory, but this is
problematic when don't call gplugin_manager_init which is private.

I ran across this as I'm porting the unit tests to stop using the default
manager and instead create an instance to help their reproducibility.

Testing Done

Ran with the turtles.

Commits

Summary	ID
Move the dependecy regex instance to the manager instance We used to do this as a global to save a tiny amount of memory, but this is problematic when don't call gplugin_manager_init which is private. I ran across this as I'm porting the unit tests to stop using the default manager and instead create an instance to help their reproducibility.	e8008750dfa31f5d49603d0a464c4831a23c7852

Change Summary:: The issue was appearing because this commit was based on the commit that is supposed to depend on this commit.
Testing Done:: ~
Ran with the turtles, but I wasgetting that dispose g_warning that weed really need to figure out.
~
Ran with the turtles.

Change Summary:

Forgot to unref the regex...

Commits:

	Summary	ID
	Move the dependecy regex instance to the manager instance We used to do this as a global to save a tiny amount of memory, but this is problematic when don't call gplugin_manager_init which is private. I ran across this as I'm porting the unit tests to stop using the default manager and instead create an instance to help their reproducibility.	d96e9057e0677813e6844e9681a204d117ea0cf4
	Move the dependecy regex instance to the manager instance We used to do this as a global to save a tiny amount of memory, but this is problematic when don't call gplugin_manager_init which is private. I ran across this as I'm porting the unit tests to stop using the default manager and instead create an instance to help their reproducibility.	e8008750dfa31f5d49603d0a464c4831a23c7852

Diff:

Revision 2 (+14 -12)

Show changes

gplugin/gplugin-manager.c

Ship it!

```
Ship It!
```

Status:: Completed

~		Ran with the turtles, but I wasgetting that dispose g_warning that weed really need to figure out.
	~	Ran with the turtles.