Summary

Create PurpleMessageModel

Review Request #2963 — Created Feb. 20, 2024 and discarded May 31, 2024, 2:18 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2968~~, ~~2962~~

Reviewers

Groups

pidgin

People

Description

This is an interface that will allow us to treat other things as messages. We
did something similar in Talkatu to make the input widget a message and this
lets us do the same thing.

This can also be used by the HistoryAdapters when pulling history out of their
backends to make updates and other stuff easier.

This will also be used as a way to transition PurpleMessage away from using
bare strings for authors and other weird things about that API, like flags, and
stuff.

Attachments were skipped for now, as this review request is already quite large.

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Create PurpleMessageModel This is an interface that will allow us to treat other things as messages. We did something similar in Talkatu to make the input widget a message and this lets us do the same thing. This can also be used by the HistoryAdapters when pulling history out of their backends to make updates and other stuff easier. This will also be used as a way to transition PurpleMessage away from using bare strings for authors and other weird things about that API, like flags, and stuff.	7517eb21f0276e9668be2edb9449c836dfcbc245

Summary

Create PurpleMessageModel

This is an interface that will allow us to treat other things as messages. We did something similar in Talkatu to make the input widget a message and this lets us do the same thing. This can also be used by the HistoryAdapters when pulling history out of their backends to make updates and other stuff easier. This will also be used as a way to transition PurpleMessage away from using bare strings for authors and other weird things about that API, like flags, and stuff.

7517eb21f0276e9668be2edb9449c836dfcbc245

Issues

Description	From	Last Updated
I'm not sure we can do this the way I was hoping. GListModel refuses to work on interfaces, which would …	grim	March 8, 2024, 4:47 a.m.
Shouldn't this also notify that the delivered property has changed?	ivanhoe	Feb. 22, 2024, 1:26 p.m.

libpurple/tests/test_message_model.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Shouldn't this also notify that the delivered property has changed?
```

Change Summary:: update the depends of the birb rr
Depends On:: ~~2968 - Add a birb_date_time API~~

Change Summary:

Updated to use birb. This will need another update when /r/2968 is merged to update the rev of birb we depend on.

Commits:

	Summary	ID
	Create PurpleMessageModel This is an interface that will allow us to treat other things as messages. We did something similar in Talkatu to make the input widget a message and this lets us do the same thing. This can also be used by the HistoryAdapters when pulling history out of their backends to make updates and other stuff easier. This will also be used as a way to transition PurpleMessage away from using bare strings for authors and other weird things about that API, like flags, and stuff.	b78a7e8e94a6ee8b749452300e668e2d7f682f45
	Create PurpleMessageModel This is an interface that will allow us to treat other things as messages. We did something similar in Talkatu to make the input widget a message and this lets us do the same thing. This can also be used by the HistoryAdapters when pulling history out of their backends to make updates and other stuff easier. This will also be used as a way to transition PurpleMessage away from using bare strings for authors and other weird things about that API, like flags, and stuff.	359ce80468548897518c7824b8052e043c42f36a

Diff:

Revision 2 (+2610)

Show changes

	libpurple/meson.build
	libpurple/purplemessagemodel.h
	libpurple/purplemessagemodel.c
	libpurple/tests/meson.build
	libpurple/tests/test_message_model.c

Change Summary:

notify the the delivered property when we notify the delivered-at property.

Commits:

	Summary	ID
	Create PurpleMessageModel This is an interface that will allow us to treat other things as messages. We did something similar in Talkatu to make the input widget a message and this lets us do the same thing. This can also be used by the HistoryAdapters when pulling history out of their backends to make updates and other stuff easier. This will also be used as a way to transition PurpleMessage away from using bare strings for authors and other weird things about that API, like flags, and stuff.	359ce80468548897518c7824b8052e043c42f36a
	Create PurpleMessageModel This is an interface that will allow us to treat other things as messages. We did something similar in Talkatu to make the input widget a message and this lets us do the same thing. This can also be used by the HistoryAdapters when pulling history out of their backends to make updates and other stuff easier. This will also be used as a way to transition PurpleMessage away from using bare strings for authors and other weird things about that API, like flags, and stuff.	aefe252109cad53d8a91222264da1be58f19d098

Diff:

Revision 3 (+2620)

Show changes

	libpurple/meson.build
	libpurple/purplemessagemodel.h
	libpurple/purplemessagemodel.c
	libpurple/tests/meson.build
	libpurple/tests/test_message_model.c

Ship it!

```
Ship It!
```

Change Summary:

Update to birb 0.1.0. I apparently missed the micro when tagging.. whoops...

Commits:

	Summary	ID
	Create PurpleMessageModel This is an interface that will allow us to treat other things as messages. We did something similar in Talkatu to make the input widget a message and this lets us do the same thing. This can also be used by the HistoryAdapters when pulling history out of their backends to make updates and other stuff easier. This will also be used as a way to transition PurpleMessage away from using bare strings for authors and other weird things about that API, like flags, and stuff.	aefe252109cad53d8a91222264da1be58f19d098
	Create PurpleMessageModel This is an interface that will allow us to treat other things as messages. We did something similar in Talkatu to make the input widget a message and this lets us do the same thing. This can also be used by the HistoryAdapters when pulling history out of their backends to make updates and other stuff easier. This will also be used as a way to transition PurpleMessage away from using bare strings for authors and other weird things about that API, like flags, and stuff.	7517eb21f0276e9668be2edb9449c836dfcbc245

Diff:

Revision 4 (+2622 -2)

Show changes

	libpurple/meson.build
	libpurple/purplemessagemodel.h
	libpurple/purplemessagemodel.c
	libpurple/tests/meson.build
	libpurple/tests/test_message_model.c
	subprojects/birb.wrap

Fix it!

An issue was opened. Show all issues

I'm not sure we can do this the way I was hoping. GListModel refuses to work on interfaces, which would break this.

Status:: Discarded
Change Summary:: GListModel refuses to work on interfaces, which would break this.