This change has been discarded.

Describe the reason it's discarded (optional):

This is super old, wasn't clear on what was going on and it's not worth the time to figure it out.

The lesson here was that the design for extension elements was incomplete and we need to rework it as not everything is under the element that's extending things.

Summary

Rework the way extension parsing works

Review Request #2957 — Created Feb. 17, 2024 and discarded 1 month, 3 weeks ago — Latest diff uploaded 1 year, 1 month ago

Information

Owner

grim*

Repository

xeme/xeme

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description*

Some extensions, like starttls have multiple elements in the same namespace. So
to support that, we're removing element names from the extensions and instead
passing the element name into the parse_start and parse_end vfuncs.

Testing Done

Ran with the turtles.
Also ran the extension and extensionmap tests under valgrind.

Changes between revision 1 and 2

orig

Commits

	Summary	ID	Author
	Add a XemeInputStream parameter to XemeExtension->parse_end This now matches the parse_start vfunc and avoids having to store the input stream on extension objects.	3f30c1a8e7023279645522b254a2ead0c38556cb	Gary Kramlich
	Rework the way extension parsing works Some extensions, like starttls have multiple elements in the same namespace. So to support that, we're removing element names from the extensions and instead passing the element name into the parse_start and parse_end vfuncs.	3db354e62dd1cc07aced9f4561827b8b3850c065	Gary Kramlich

Files

	xeme/xemeextension.h
	xeme/xemeextension.c
	xeme/xemeextensionmap.h
	xeme/xemeextensionmap.c
	xeme/tests/testextension.c
	xeme/tests/testextensionmap.c

xeme/xemeextension.h

xeme/xemeextension.c

xeme/xemeextensionmap.h

xeme/xemeextensionmap.c

xeme/tests/testextension.c

xeme/tests/testextensionmap.c