Summary

Remove unnecessary casts for GObject methods

Review Request #2956 — Created Feb. 17, 2024 and submitted Feb. 20, 2024, 6:56 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2955~~

Reviewers

Groups

pidgin

People

Description

Remove unnecessary casts for GObject methods

Testing Done

Compiled with the turtles and verified no new warnings appeared.

Commits

Summary	ID
Remove unnecessary casts for GObject methods	c8037c60c5fc7b18649072d81f92207f354ba939

Issues

Description	From	Last Updated
This could be FINCH_TYPE_MEDIA for consistency.	QuLogic	Feb. 18, 2024, 7:54 a.m.
Could be PURPLE_TYPE_MEDIA_MANAGER as well.	QuLogic	Feb. 18, 2024, 7:54 a.m.
And PURPLE_TYPE_MEDIA.	QuLogic	Feb. 18, 2024, 7:54 a.m.
This should be PURPLE_TYPE_MEDIA, not PURPLE_TYPE_MEDIA_MANAGER.	QuLogic	Feb. 18, 2024, 8:07 a.m.

finch/gntmedia.c (Diff revision 1)
The issue has been resolved. Show all issues
```
This could be FINCH_TYPE_MEDIA for consistency.
```
libpurple/mediamanager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Could be PURPLE_TYPE_MEDIA_MANAGER as well.
```
libpurple/mediamanager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
And PURPLE_TYPE_MEDIA.
```

Change Summary:

use _TYPE_ macros instead of _get_type functions.

Commits:

	Summary	ID
	Remove unnecessary casts for GObject methods	39b40178bc4957f9f6e1d98f399e7dc71ea494d7
	Remove unnecessary casts for GObject methods	f88a602623a435f04158fa67748f1ccf042c47a4

Diff:

Revision 2 (+276 -276)

Show changes

	finch/gntaccount.c
	finch/gntmedia.c
	finch/gntroomlist.c
	finch/plugins/grouping/grouping.c
	libpurple/media.c
	libpurple/mediamanager.c
	libpurple/purpleattachment.c
	libpurple/purpleconversation.c
	36 more

```
Ship It!
```

libpurple/mediamanager.c (Diff revisions 1 - 2)
The issue has been resolved. Show all issues
```
This should be PURPLE_TYPE_MEDIA, not PURPLE_TYPE_MEDIA_MANAGER.
```

Change Summary:

fix the wrong type macro

Commits:

	Summary	ID
	Remove unnecessary casts for GObject methods	f88a602623a435f04158fa67748f1ccf042c47a4
	Remove unnecessary casts for GObject methods	0f020e7be8ca11b3fd2b88a985786c7aa84a647c

Diff:

Revision 3 (+276 -276)

Show changes

	finch/gntaccount.c
	finch/gntmedia.c
	finch/gntroomlist.c
	finch/plugins/grouping/grouping.c
	libpurple/media.c
	libpurple/mediamanager.c
	libpurple/purpleattachment.c
	libpurple/purpleconversation.c
	36 more

Ship it!

```
Ship It!
```

Change Summary:

rebased, fixed some conflicts.

Commits:

	Summary	ID
	Remove unnecessary casts for GObject methods	0f020e7be8ca11b3fd2b88a985786c7aa84a647c
	Remove unnecessary casts for GObject methods	c8037c60c5fc7b18649072d81f92207f354ba939

Diff:

Revision 4 (+276 -276)

Show changes

	finch/gntaccount.c
	finch/gntmedia.c
	finch/gntroomlist.c
	finch/plugins/grouping/grouping.c
	libpurple/media.c
	libpurple/mediamanager.c
	libpurple/purpleattachment.c
	libpurple/purpleconversation.c
	36 more

Status:: Completed

finch/gntmedia.c (Diff revision 1)

libpurple/mediamanager.c (Diff revision 1)

libpurple/mediamanager.c (Diff revision 1)

libpurple/mediamanager.c (Diff revisions 1 - 2)