Summary

Use g_task_set_source_tag on all of our async methods

Review Request #2955 — Created Feb. 17, 2024 and submitted Feb. 20, 2024, 12:41 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

2956

Reviewers

Groups

pidgin

People

Description

This is supposed to help with debugging and profiling per the docs for
g_task_set_name, which is automatically called by g_task_set_source_tag in
glib >= 2.76.0 which is our minimum requirement.

Testing Done

Consulted with the turtles

Commits

Summary	ID
Use g_task_set_source_tag on all of our async methods This is supposed to help with debugging and profiling per the docs for g_task_set_name, which is automatically called by g_task_set_source_tag in glib >= 2.76.0 which is our minimum requirement.	ab7924c938392f9b0975372f8868e30caaa0d592

Issues

Description	From	Last Updated
Does the name get set correctly here? Or does it stringify to "(gpointer)purple_kwallet_read_password_async"?	QuLogic	Feb. 20, 2024, 12:20 a.m.

libpurple/plugins/kwallet/purplekwallet.cpp (Diff revision 1)

The issue has been resolved. Show all issues

Does the name get set correctly here? Or does it stringify to "(gpointer)purple_kwallet_read_password_async"?

grim Feb. 18, 2024, 1:48 a.m.

that's a great question, I need to look into that...

grim Feb. 18, 2024, 8:29 p.m.

(pidgin3:1120247): Purple-KWalletKeyring-WARNING **: 20:28:13.482: source name: '(gpointer)purple_kwallet_read_password_async'

Manually setting the name ahead of time avoids the issue.

Change Summary:

Use g_task_set_static_name before g_task_set_source_tag for the kwallet stuff as it requires a (gpointer) cast which is ending up in the name.

Commits:

	Summary	ID
	Use g_task_set_source_tag on all of our async methods This is supposed to help with debugging and profiling per the docs for g_task_set_name, which is automatically called by g_task_set_source_tag in glib >= 2.76.0 which is our minimum requirement.	1e026cbb93ddbf53be185b0cca61977f8edc2ef3
	Use g_task_set_source_tag on all of our async methods This is supposed to help with debugging and profiling per the docs for g_task_set_name, which is automatically called by g_task_set_source_tag in glib >= 2.76.0 which is our minimum requirement.	ab7924c938392f9b0975372f8868e30caaa0d592

Diff:

Revision 2 (+98 -10)

Show changes

	libpurple/purplecredentialmanager.c
	libpurple/purplenoopcredentialprovider.c
	libpurple/plugins/keychain-access/keychain-access.c
	libpurple/plugins/kwallet/purplekwallet.cpp
	libpurple/plugins/libsecret/libsecret.c
	libpurple/plugins/wincred/wincred.c

Ship it!

```
Ship It!
```

Status:: Completed