Summary

Add purple_saved_presence_matches to enable searching in UIs

Review Request #2942 — Created Jan. 30, 2024 and submitted Feb. 1, 2024, 10:22 p.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Add purple_saved_presence_matches to enable searching in UIs

Testing Done

Consulted with Turtles and ran the unit tests under valgrind.

Commits

Summary	ID
Add purple_saved_presence_matches to enable searching in UIs	612a16bf41f2a65ba577237ad5e602bdf16c890e

Issues

Description	From	Last Updated
I think there's no need for this outer check, as purple_strmatches already checks purple_strempty and returns FALSE.	QuLogic	Feb. 1, 2024, 10:21 p.m.
Ditto.	QuLogic	Feb. 1, 2024, 10:21 p.m.
Ditto.	QuLogic	Feb. 1, 2024, 10:21 p.m.

libpurple/purplesavedpresence.c (Diff revision 1)

The issue has been resolved. Show all issues

I think there's no need for this outer check, as purple_strmatches already checks purple_strempty and returns FALSE.

libpurple/purplesavedpresence.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto.
```
libpurple/purplesavedpresence.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto.
```

Testing Done:: ~
Consulted withe Turtles and ran the unit tests under valgrind.
~
Consulted with Turtles and ran the unit tests under valgrind.

Change Summary:

addressed issues

Commits:

	Summary	ID
	Add purple_saved_presence_matches to enable searching in UIs	2ec1890c076251bda1be86f9d734a5d6ad4769df
	Add purple_saved_presence_matches to enable searching in UIs	612a16bf41f2a65ba577237ad5e602bdf16c890e

Diff:

	libpurple/purplesavedpresence.h
	libpurple/purplesavedpresence.c
	libpurple/tests/test_saved_presence.c

Ship it!

~		Consulted withe Turtles and ran the unit tests under valgrind.
	~	Consulted with Turtles and ran the unit tests under valgrind.