Summary

Make sure all of the final types in libpurple are defined as such

Review Request #2922 — Created Jan. 20, 2024 and submitted Jan. 23, 2024, 6:32 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Make sure all of the final types in libpurple are defined as such

Testing Done

Compiled and ran the tests.

Commits

Summary	ID
Make sure all of the final types in libpurple are defined as such	55d73e6db5793617b27840d83bc48f3df933f014

Issues

Description	From	Last Updated
Missed a few: - PurpleConversationMember - PurpleQueuedOutputStream (though maybe that should be deleted soon) - PurpleMediaElementInfo - PurpleMediaManager	QuLogic	Jan. 23, 2024, 6:30 a.m.

The issue has been resolved. Show all issues

Missed a few:
- PurpleConversationMember
- PurpleQueuedOutputStream (though maybe that should be deleted soon)
- PurpleMediaElementInfo
- PurpleMediaManager

Change Summary:

Fix the ones I missed. I skipped QueuedOutputStream as we need to use the one in birb and then just delete the one in our codebase.

Commits:

	Summary	ID
	Make sure all of the final types in libpurple are defined as such	1f8a01d58ea8efb7e0919494f1bd00bfed215682
	Make sure all of the final types in libpurple are defined as such	55d73e6db5793617b27840d83bc48f3df933f014

Diff:

Revision 2 (+304 -278)

Show changes

	libpurple/mediamanager.c
	libpurple/purpleaccount.c
	libpurple/purpleaccountmanager.c
	libpurple/purpleaccountpresence.c
	libpurple/purpleaddcontactrequest.c
	libpurple/purpleattachment.c
	libpurple/purpleauthorizationrequest.c
	libpurple/purpleavatar.c
	47 more

Ship it!

```
Ship It!
```

Status:: Completed