Summary

Redesign the presence manager a bit

Review Request #2912 — Created Jan. 12, 2024 and submitted Jan. 23, 2024, 6:05 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

The presence manager now stores everything in a directory rather than a single
ini file. This avoids relocating schemas which seems to have a number of
issues.

Also bind the "active" setting to the "active-presence" property so that you
can change the active presence via the `manager.ini` gsettings keyfile.

So other various tweaks as well.

Testing Done

Opened manager.ini and toggled the active status between a few I created.

Consulted with the turtles and ran the presence_manager and saved_presence unit tests under valgrind.

Commits

Summary	ID
Redesign the presence manager a bit The presence manager now stores everything in a directory rather than a single ini file. This avoids relocating schemas which seems to have a number of issues. Also bind the "active" setting to the "active-presence" property so that you can change the active presence via the `manager.ini` gsettings keyfile. So other various tweaks as well.	9a8d0ab7b43e41b4d75e737a1038d9141b38b22b

Issues

Description	From	Last Updated
This is outdated now?	QuLogic	Jan. 23, 2024, 5:37 a.m.
Comma after @presense.	QuLogic	Jan. 23, 2024, 5:33 a.m.
Kind of a silly question, but I wonder if available should be all f and offline be all 0 (i.e., …	QuLogic	Jan. 23, 2024, 5:37 a.m.
Maybe this should say "directory path", as I don't think anywhere says it's a directory vs a file?	QuLogic	Jan. 23, 2024, 5:33 a.m.
Any reason to remove the assert?	QuLogic	Jan. 23, 2024, 5:38 a.m.

libpurple/data/im.pidgin.Purple.PresenceManager.gschema.xml (Diff revision 1)
The issue has been resolved. Show all issues
```
This is outdated now?
```
libpurple/purplepresencemanager.h (Diff revision 1)
The issue has been resolved. Show all issues
```
Comma after @presense.
```

libpurple/purplepresencemanager.c (Diff revision 1)

The issue has been resolved. Show all issues

Kind of a silly question, but I wonder if available should be all f and offline be all 0 (i.e., available is as "on" as possible, and offline is as "off" as possible)?

grim Jan. 20, 2024, 5:17 a.m.
```
That's a really good idea!
```

libpurple/purplepresencemanager.c (Diff revision 1)

The issue has been resolved. Show all issues

Maybe this should say "directory path", as I don't think anywhere says it's a directory vs a file?

libpurple/tests/test_presence_manager.c (Diff revision 1)

The issue has been resolved. Show all issues

Any reason to remove the assert?

grim Jan. 20, 2024, 5:17 a.m.

I think I removed it as it was being tested elsewhere or something, but whatever, it's a single line so I'll put it back.

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Redesign the presence manager a bit The presence manager now stores everything in a directory rather than a single ini file. This avoids relocating schemas which seems to have a number of issues. Also bind the "active" setting to the "active-presence" property so that you can change the active presence via the `manager.ini` gsettings keyfile. So other various tweaks as well.	5bfe90930d65a027d20381053757fef1226637f4
	Redesign the presence manager a bit The presence manager now stores everything in a directory rather than a single ini file. This avoids relocating schemas which seems to have a number of issues. Also bind the "active" setting to the "active-presence" property so that you can change the active presence via the `manager.ini` gsettings keyfile. So other various tweaks as well.	9a8d0ab7b43e41b4d75e737a1038d9141b38b22b

Diff:

Revision 2 (+462 -588)

Show changes

	libpurple/meson.build
	libpurple/purplepresencemanager.h
	libpurple/purplepresencemanager.c
	libpurple/purplesavedpresence.c
	libpurple/purplesavedpresenceprivate.h
	libpurple/data/im.pidgin.Purple.PresenceManager.gschema.xml
	libpurple/tests/test_presence_manager.c
	libpurple/tests/test_saved_presence.c
	1 more

Ship it!

```
Ship It!
```

Status:: Completed