Summary

Make the application wide shortcuts work again

Review Request #2906 — Created Jan. 1, 2024 and submitted Jan. 2, 2024, 6:34 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

This only fixes the menu shortcuts but is a start point for moving many things
to the action based shortcuts.

Testing Done

Ran the program and verified the shortcuts worked.

Commits

Summary	ID
Make the application wide shortcuts work again This only fixes the menu shortcuts but is a start point for moving many things to the action based shortcuts.	6e6b38d953cfbbf6eb0adcdf795696c826b02949

Issues

Description	From	Last Updated
Is visible not true by default?	QuLogic	Jan. 2, 2024, 6:11 a.m.
Don't need this any more, I think?	QuLogic	Jan. 2, 2024, 6:11 a.m.

Change Summary:

add the missing help-overlay.ui file.

Commits:

	Summary	ID
	Make the application wide shortcuts work again This only fixes the menu shortcuts but is a start point for moving many things to the action based shortcuts.	09f8fa951e848eec7db64b97f14dc610d4da2ef3
	Make the application wide shortcuts work again This only fixes the menu shortcuts but is a start point for moving many things to the action based shortcuts.	49e635596b96d264bf1e3ad45b2c1c69fa8b3729

Diff:

Revision 2 (+256 -14)

	pidgin/pidginapplication.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/gtk/help-overlay.ui
	pidgin/resources/gtk/menus.ui

pidgin/resources/gtk/help-overlay.ui (Diff revision 2)
The issue has been resolved. Show all issues
```
Is visible not true by default?
```
1. grim Jan. 2, 2024, 5:56 a.m.
  It is, the examples I used had this set, and I forgot to delete it.
pidgin/resources/gtk/help-overlay.ui (Diff revision 2)
The issue has been resolved. Show all issues
```
Don't need this any more, I think?
```

Change Summary:

Addressed issues

Commits:

	Summary	ID
	Make the application wide shortcuts work again This only fixes the menu shortcuts but is a start point for moving many things to the action based shortcuts.	49e635596b96d264bf1e3ad45b2c1c69fa8b3729
	Make the application wide shortcuts work again This only fixes the menu shortcuts but is a start point for moving many things to the action based shortcuts.	6e6b38d953cfbbf6eb0adcdf795696c826b02949

Diff:

Revision 3 (+252 -14)

	pidgin/pidginapplication.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/gtk/help-overlay.ui
	pidgin/resources/gtk/menus.ui

Ship it!