Summary

Stub out our new modern XMPP implementation

Review Request #2856 — Created Nov. 30, 2023 and submitted Dec. 1, 2023, 4:18 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This doesn't do anything except show up in the protocol list.

Testing Done

Verified the protocol showed up in the protocol list.

Commits

Summary	ID
Stub out our new modern XMPP implementation This doesn't do anything except show up in the protocol list.	e0b7793f782d442c5d4309fa1c3a16755693d8ef

Issues

Description	From	Last Updated
Copy comment to empty block.	QuLogic	Dec. 1, 2023, 4:06 a.m.
Wrong directory? But I guess this isn't installed, so maybe that would be where it ended up if it were?	QuLogic	Dec. 1, 2023, 4:06 a.m.
No resource this time?	QuLogic	Dec. 1, 2023, 4:06 a.m.
Alignment is off.	QuLogic	Dec. 1, 2023, 4:06 a.m.

meson.build (Diff revision 1)
The issue has been resolved. Show all issues
```
Copy comment to empty block.
```

protocols/xmpp/purplexmppcore.h (Diff revision 1)

The issue has been resolved. Show all issues

Wrong directory? But I guess this isn't installed, so maybe that would be where it ended up if it were?

grim Dec. 1, 2023, 3:50 a.m.

That was my thought. But actually this should just be removed because i'm hoping/assuming we don't need to subclass this and thus don't have to expose it.

protocols/xmpp/purplexmppprotocol.c (Diff revision 1)

The issue has been dropped. Show all issues

No resource this time?

grim Dec. 1, 2023, 3:50 a.m.

I want to moved that to an advanced option as most users rightfully have no idea what it is.

protocols/xmpp/purplexmppprotocol.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Alignment is off.
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Stub out our new modern XMPP implementation This doesn't do anything except show up in the protocol list.	bc705cb13e57d621e35b673a07f368b247921043
	Stub out our new modern XMPP implementation This doesn't do anything except show up in the protocol list.	e0b7793f782d442c5d4309fa1c3a16755693d8ef

Diff:

Revision 2 (+692 -20)

Show changes

	meson.build
	protocols/meson.build
	protocols/xmpp/meson.build
	protocols/xmpp/purplexmppcore.h
	protocols/xmpp/purplexmppcore.c
	protocols/xmpp/purplexmppprotocol.h
	protocols/xmpp/purplexmppprotocol.c
	libpurple/protocols/jabber/resources/xmpp.gresource.xml
	7 more

Ship it!

```
Ship It!
```

Status:: Completed