Summary

Merge PurpleProtocolContactsSearch into PurpleProtocolContacts

Review Request #2852 — Created Nov. 28, 2023 and submitted Dec. 4, 2023, 2:09 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

The former was created before the later and hadn't been moved yet.

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Merge PurpleProtocolContactsSearch into PurpleProtocolContacts The former was created before the later and hadn't been moved yet.	d25dc65960dc55939e98f5eb25f58b01b7651513

Issues

Description	From	Last Updated
Shouldn't purpleprotocolcontactsearch.[ch] be deleted?	QuLogic	Dec. 4, 2023, 2:07 a.m.
A domain	QuLogic	Dec. 4, 2023, 2:07 a.m.
Double a	QuLogic	Dec. 4, 2023, 2:07 a.m.

The issue has been resolved. Show all issues

Shouldn't purpleprotocolcontactsearch.[ch] be deleted?

libpurple/purpleprotocolcontacts.h (Diff revision 1)
The issue has been resolved. Show all issues
```
A domain
```
libpurple/purpleprotocolcontacts.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Double a
```

Change Summary:

rebased and addressed issues.

Commits:

	Summary	ID
	Merge PurpleProtocolContactsSearch into PurpleProtocolContacts The former was created before the later and hadn't been moved yet.	5c8a930e629b1bd47e554802ebd40665ae2a8142
	Merge PurpleProtocolContactsSearch into PurpleProtocolContacts The former was created before the later and hadn't been moved yet.	d25dc65960dc55939e98f5eb25f58b01b7651513

Diff:

Revision 2 (+600 -1082)

	libpurple/meson.build
	libpurple/purpleprotocolcontacts.h
	libpurple/purpleprotocolcontacts.c
	libpurple/purpleprotocolcontactsearch.h
	libpurple/purpleprotocolcontactsearch.c
	libpurple/tests/meson.build
	libpurple/tests/test_protocol_contact_search.c
	libpurple/tests/test_protocol_contacts.c

Ship it!