Summary

IRCv3: Add an ircv3_connection_find_or_create_contact

Review Request #2830 — Created Nov. 17, 2023 and submitted Nov. 19, 2023, 12:52 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Also use it in the privmsg handler

Testing Done

Had people randomly send messages on twitch.

Commits

Summary	ID
IRCv3: Add an ircv3_connection_find_or_create_contact Also use it in the privmsg handler	41f30f9c83e17b64a1dea4e0ff7b56e626f35530

Issues

Description	From	Last Updated
s/belong/belonging/	QuLogic	Nov. 19, 2023, 12:44 a.m.
s/THis/This/	QuLogic	Nov. 19, 2023, 12:44 a.m.
Blank line between Returns and Since.	QuLogic	Nov. 19, 2023, 12:44 a.m.
Is this necessary for existing contacts?	QuLogic	Nov. 19, 2023, 12:44 a.m.
This variable looks like it could be contained in the if scope below.	QuLogic	Nov. 19, 2023, 12:44 a.m.

libpurple/protocols/ircv3/purpleircv3connection.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/belong/belonging/
```
libpurple/protocols/ircv3/purpleircv3connection.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/THis/This/
```
libpurple/protocols/ircv3/purpleircv3connection.h (Diff revision 1)
The issue has been resolved. Show all issues
```
Blank line between Returns and Since.
```
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Is this necessary for existing contacts?
```
libpurple/protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)
The issue has been resolved. Show all issues
```
This variable looks like it could be contained in the if scope below.
```

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	IRCv3: Add an ircv3_connection_find_or_create_contact Also use it in the privmsg handler	ca39f20f3ba3fad5c5abc5179f67f5fd0d4a090c
	IRCv3: Add an ircv3_connection_find_or_create_contact Also use it in the privmsg handler	41f30f9c83e17b64a1dea4e0ff7b56e626f35530

Diff:

Revision 2 (+122 -32)

	libpurple/protocols/ircv3/purpleircv3connection.h
	libpurple/protocols/ircv3/purpleircv3connection.c
	libpurple/protocols/ircv3/purpleircv3messagehandlers.c

Ship it!