Summary

IRCv3: Add support for updating topics

Review Request #2817 — Created Nov. 14, 2023 and submitted Nov. 16, 2023, 9:27 p.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

This only sets the text as we need a helper to find or create a contact info to
do the topic author.

Testing Done

Set and unset the topic from another client and verified it was displayed correctly including on join.

Commits

Summary	ID
IRCv3: Add support for updating topics This only sets the text as we need a helper to find or create a contact info to do the topic author.	b8e823b72d8e962177c7be3e97582420e45b2541

Issues

Description	From	Last Updated
error not unused	ivanhoe	Nov. 16, 2023, 5:42 a.m.
Oh, should the constants be used here too?	ivanhoe	Nov. 16, 2023, 3:07 p.m.

Change Summary:

rebased, addressed issue, added support for constants for messages and replies. Will fill out the rest of them in another rr.

Commits:

	Summary	ID
	IRCv3: Add support for updating topics This only sets the text as we need a helper to find or create a contact info to do the topic author.	93d80f57c5361733063b31ac44be495ce5e00173
	IRCv3: Add support for updating topics This only sets the text as we need a helper to find or create a contact info to do the topic author.	fa45badc4c2c67ee94865b79d466a248c48447dc

Diff:

	libpurple/protocols/ircv3/meson.build
	libpurple/protocols/ircv3/purpleircv3constants.h
	libpurple/protocols/ircv3/purpleircv3messagehandlers.h
	libpurple/protocols/ircv3/purpleircv3messagehandlers.c
	libpurple/protocols/ircv3/purpleircv3parser.c

Ship it!

Change Summary:

Use constants when registering the handlers and move to defines because we can't keep defining string variables in a header file.

Commits:

	Summary	ID
	IRCv3: Add support for updating topics This only sets the text as we need a helper to find or create a contact info to do the topic author.	fa45badc4c2c67ee94865b79d466a248c48447dc
	IRCv3: Add support for updating topics This only sets the text as we need a helper to find or create a contact info to do the topic author.	b8e823b72d8e962177c7be3e97582420e45b2541

Diff:

	libpurple/protocols/ircv3/meson.build
	libpurple/protocols/ircv3/purpleircv3constants.h
	libpurple/protocols/ircv3/purpleircv3messagehandlers.h
	libpurple/protocols/ircv3/purpleircv3messagehandlers.c
	libpurple/protocols/ircv3/purpleircv3parser.c