Summary

Fix warnings from clang

Review Request #2785 — Created Nov. 7, 2023 and submitted Nov. 7, 2023, 1:34 a.m.

Owner

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

This fixes a 'missing struct initializer' warning, and a read out-of-bounds of
a static array.

Also, delete an unused struct typedef.

Testing Done

Compiled with clang and saw fewer warnings.

Commits

Summary	ID
Fix warnings from clang This fixes a 'missing struct initializer' warning, and a read out-of-bounds of a static array. Also, delete an unused struct typedef.	cde3ed9ef057fcac23535ac3f9556d85a1de3200

Issues

Description	From	Last Updated
Per the docs we should be using G_OPTION_ENTRY_NULL	grim	Nov. 7, 2023, 1:33 a.m.

libpurple/purpleoptions.c (Diff revision 1)

The issue has been resolved. Show all issues

Per the docs we should be using G_OPTION_ENTRY_NULL

I misinterpreted it at first, but yes, that seems to work as well.

Change Summary:

Fixed review comments.

Commits:

	Summary	ID
	Fix warnings from clang This fixes a 'missing struct initializer' warning, and a read out-of-bounds of a static array. Also, delete an unused struct typedef.	b866179d1ea838d0d4c3b31b094abae4b6a1faee
	Fix warnings from clang This fixes a 'missing struct initializer' warning, and a read out-of-bounds of a static array. Also, delete an unused struct typedef.	cde3ed9ef057fcac23535ac3f9556d85a1de3200

Diff:

Ship it!