Summary

Give GPluginGtk its own versioning macros

Review Request #2778 — Created Nov. 5, 2023 and submitted Nov. 6, 2023, 1:27 a.m.

Information

Owner

grim

Repository

gplugin/gplugin

Branch

default

Bugs

GPLUGIN-147

Depends On

Reviewers

Groups

pidgin

People

Description

Give GPluginGtk its own versioning macros

Testing Done

Compiled.

Commits

Summary	ID
Give GPluginGtk it's own versioning macros	6a187f026d99edc3b249a500e2143b10e91f23d5

Issues

Description	From	Last Updated
s/it's/its/	QuLogic	Nov. 5, 2023, 6:08 p.m.
of GPlugin-GTK?	QuLogic	Nov. 5, 2023, 10:30 p.m.
Same here and then all versions below.	QuLogic	Nov. 5, 2023, 10:30 p.m.
Was there a reason to use the GPluginGtk4 prefix on one and not the other two?	QuLogic	Nov. 6, 2023, 1:12 a.m.

Change Summary:: add the bug this is for.
Bugs:: GPLUGIN-147

The issue has been resolved. Show all issues
```
s/it's/its/
```
gplugin-gtk4/gplugin-gtk-version.h (Diff revision 1)
The issue has been resolved. Show all issues
```
of GPlugin-GTK?
```
gplugin-gtk4/gplugin-gtk-version.h (Diff revision 1)
The issue has been resolved. Show all issues
```
Same here and then all versions below.
```

Summary:: Give GPluginGtk it's own versioning macros
Give GPluginGtk its own versioning macros
Description:: ~
Give GPluginGtk it's own versioning macros
~
Give GPluginGtk its own versioning macros

Change Summary:

Address issues and add the missing api.

Commits:

	Summary	ID
	Give GPluginGtk it's own versioning macros	1b5b46e4b53ed65759ccd630ca42f34a3ba381e9
	Give GPluginGtk it's own versioning macros	3d09ea5ca71bd9bbedaf14c476a4cfc594ed4275

Diff:

Revision 2 (+504 -768)

Show changes

	meson.build
	gplugin-gtk4/gplugin-gtk-plugin-closures.h
	gplugin-gtk4/gplugin-gtk-plugin-page.h
	gplugin-gtk4/gplugin-gtk-plugin-row.h
	gplugin-gtk4/gplugin-gtk-plugin-settings-list.h
	gplugin/gplugin-version.h
	gplugin/gplugin-version.c
	gplugin/gplugin-version-defs.h.in
	2 more

gplugin-gtk4/gplugin-gtk-version.c (Diff revision 2)

The issue has been resolved. Show all issues

Was there a reason to use the GPluginGtk4 prefix on one and not the other two?

grim Nov. 6, 2023, 1:07 a.m.

I was running into issues and that was part of my debugging, but clearly it didn't fix the issue and I missed removing it...

Change Summary:

address issues

Commits:

	Summary	ID
	Give GPluginGtk it's own versioning macros	3d09ea5ca71bd9bbedaf14c476a4cfc594ed4275
	Give GPluginGtk it's own versioning macros	6a187f026d99edc3b249a500e2143b10e91f23d5

Diff:

Revision 3 (+504 -768)

Show changes

	meson.build
	gplugin-gtk4/gplugin-gtk-plugin-closures.h
	gplugin-gtk4/gplugin-gtk-plugin-page.h
	gplugin-gtk4/gplugin-gtk-plugin-row.h
	gplugin-gtk4/gplugin-gtk-plugin-settings-list.h
	gplugin/gplugin-version.h
	gplugin/gplugin-version.c
	gplugin/gplugin-version-defs.h.in
	2 more

Ship it!

```
Ship It!
```

Status:: Completed