Summary

Add symbol visibility on IRCv3 protocol plugin

Review Request #2773 — Created Nov. 3, 2023 and submitted Nov. 3, 2023, 4:43 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17840

Depends On

Reviewers

Groups

pidgin

People

Description

This only adds visibility to things that have Since: 3.0.0 and are not already tagged with G_GNUC_INTERNAL.

It also assumes that the version is the same as libpurple, but that 3.0 is the minimum instead of 2.0, so everything is PURPLE_IRCV3_AVAILABLE_IN_ALL.

Testing Done

Compiled on Linux and Windows.

Commits

Summary	ID
Add symbol visibility on IRCv3 protocol plugin	397b29d917c732cfdae9f5db661698969bb9a02e

Issues

Description	From	Last Updated
s/libpurple/purple ircv3/	grim	Nov. 3, 2023, 4:38 a.m.

Change Summary:: Add bug reference.
Bugs:: PIDGIN-17840

libpurple/protocols/ircv3/purpleircv3version.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/libpurple/purple ircv3/
```

Change Summary:

Fix copy&paste typo.

Commits:

	Summary	ID
	Add symbol visibility on IRCv3 protocol plugin	c534138a8f16459987386c33fb8e8528235b13fd
	Add symbol visibility on IRCv3 protocol plugin	397b29d917c732cfdae9f5db661698969bb9a02e

Diff:

Revision 2 (+336)

Show changes

	libpurple/protocols/ircv3/meson.build
	libpurple/protocols/ircv3/purpleircv3capabilities.h
	libpurple/protocols/ircv3/purpleircv3connection.h
	libpurple/protocols/ircv3/purpleircv3message.h
	libpurple/protocols/ircv3/purpleircv3messagehandlers.h
	libpurple/protocols/ircv3/purpleircv3parser.h
	libpurple/protocols/ircv3/purpleircv3source.h
	libpurple/protocols/ircv3/purpleircv3version.h

Ship it!

```
Great work, thanks!!
```

Status:: Completed