Summary

Fix a Windows-specific preproc condition

Review Request #2702 — Created Oct. 25, 2023 and submitted Oct. 25, 2023, 3:34 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

In MSVC 2019, vsnprintf became a real function that correctly matches the C99 standard, and as it's no longer a macro, it cannot be #undef'd. This causes a Macro redefinition conflict with the Standard Library function.
I assume that the only two options here were Mingw and MSVC. I would guess Cygwin would also fall under Mingw. I also assumed that the "not cross-compiling" meant MSVC. So this condition should now correctly target either of those two options.

Testing Done

Compiled on MSVC, and it no longer errored.

Commits

Summary	ID
Fix a Windows-specific preproc condition	eff18cd71e3f37136072d349887197f68fbef924

Issues

Description	From	Last Updated
Does #ifdef work on non-macros? I didn't think it did, so couldn't we just use #ifdef vsnprintf?	grim	Oct. 25, 2023, 3:31 a.m.

libpurple/win32/libc_interface.h (Diff revision 1)

The issue has been dropped. Show all issues

Does #ifdef work on non-macros? I didn't think it did, so couldn't we just use #ifdef vsnprintf?

QuLogic Oct. 25, 2023, 3:16 a.m.

I'm not sure what the ordering of stuff is, but that doesn't seem to work, as the MSVC stdio.h still complains about the redefinition. Also, I don't really know what the Mingw headers do, I just preserved its condition.

QuLogic Oct. 25, 2023, 3:18 a.m.

Actually, I accidentally did #ifndef instead of #ifdef which does work, but the latter point still stands for now.

grim Oct. 25, 2023, 3:19 a.m.

Which later point is that, your's or mine? :-D

QuLogic Oct. 25, 2023, 3:21 a.m.

I mean we could use #ifdef vsnprintf for MSVC, but I'm not sure how the Mingw headers do it.

grim Oct. 25, 2023, 3:32 a.m.
```
Gotcha, whatever is fine for now :)
```

Ship it!

```
Great work, thanks!!
```

Status:: Completed