Summary

IRCv3: Fix an issue scanbuild found

Review Request #2682 — Created Oct. 21, 2023 and submitted Oct. 23, 2023, 1:47 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

This is only triggerably via a malicious server, but easy to fix so whatever.

Testing Done

Sent some messages in a channel.

Commits

Summary	ID
IRCv3: Fix an issue scanbuild found This is only triggerably via a malicious server, but easy to fix so whatever.	239cf6f618e66fc70a234d8157cde6859be4245a

Issues

Description	From	Last Updated
Is g_strjoinv okay with NULL input? It doesn't seem to mention it.	QuLogic	Oct. 23, 2023, 1:45 a.m.

libpurple/protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)

The issue has been resolved. Show all issues

Is g_strjoinv okay with NULL input? It doesn't seem to mention it.

ugh you're right, this is the wrong fix. This is what I get for bring to be logical when I can't fall asleep...

Change Summary:

rebased and fixed this better.

Commits:

	Summary	ID
	IRCv3: Fix an issue scanbuild found This is only triggerably via a malicious server, but easy to fix so whatever.	0080461ff132605f57a900db7314bc5ca65e5af6
	IRCv3: Fix an issue scanbuild found This is only triggerably via a malicious server, but easy to fix so whatever.	239cf6f618e66fc70a234d8157cde6859be4245a

Diff:

Ship it!