Summary

Add PurpleIRCv3Message represent messages rather than multiple variables

Review Request #2620 — Created Sept. 19, 2023 and submitted Oct. 3, 2023, 5:06 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Add PurpleIRCv3Message represent messages rather than multiple variables

Testing Done

Ran the unit tests and connected to my local ergo and sent a few messages.

Commits

Summary	ID
Add PurpleIRCv3Message represent messages rather than multiple variables	b69d690613f281939b245d773d45af59952d8b04

Issues

Description	From	Last Updated
s/messaget/message	ivanhoe	Sept. 30, 2023, 7:34 a.m.
Before purple_ircv3_connection_add_status_message was called with new_command, now new_command is not used at all.	ivanhoe	Sept. 30, 2023, 7:35 a.m.
The first param is not ignored here anymore.	ivanhoe	Sept. 30, 2023, 7:36 a.m.
n_params unused	ivanhoe	Sept. 30, 2023, 7:37 a.m.

libpurple/protocols/ircv3/purpleircv3message.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/messaget/message
```

libpurple/protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)

The issue has been resolved. Show all issues

Before purple_ircv3_connection_add_status_message was called with new_command, now new_command is not used at all.

libpurple/protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)
The issue has been resolved. Show all issues
```
The first param is not ignored here anymore.
```
libpurple/protocols/ircv3/purpleircv3parser.c (Diff revision 1)
The issue has been resolved. Show all issues
```
n_params unused
```

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	Add PurpleIRCv3Message represent messages rather than multiple variables	0af0a4d47134a8593fb0ef51dfb1628be4b12808
	Add PurpleIRCv3Message represent messages rather than multiple variables	b69d690613f281939b245d773d45af59952d8b04

Diff:

Revision 2 (+1178 -338)

	libpurple/protocols/ircv3/meson.build
	libpurple/protocols/ircv3/purpleircv3capabilities.h
	libpurple/protocols/ircv3/purpleircv3capabilities.c
	libpurple/protocols/ircv3/purpleircv3connection.h
	libpurple/protocols/ircv3/purpleircv3connection.c
	libpurple/protocols/ircv3/purpleircv3message.h
	libpurple/protocols/ircv3/purpleircv3message.c
	libpurple/protocols/ircv3/purpleircv3messagehandlers.h
	5 more

Ship it!