Summary

Add a secondary id property to PurpleContactInfo

Review Request #2610 — Created Sept. 6, 2023 and submitted Sept. 19, 2023, 6:35 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

This is meant to give the protocol to add a single additional identifier to a
contact. Something like an XMPP resource or IRC ident.

Testing Done

Ran the unit tests under valgrind.

Commits

Summary	ID
Add a secondary id property to PurpleContactInfo This is meant to give the protocol to add a single additional identifier to a contact. Something like an XMPP resource or IRC ident.	b91c8d560ce93d424fc5f9f9d8eedcc06c12f1f4

Issues

Description	From	Last Updated
Double 'for'	QuLogic	Sept. 19, 2023, 6:23 a.m.
This change seems unrelated?	QuLogic	Sept. 19, 2023, 6:23 a.m.

libpurple/purplecontactinfo.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Double 'for'
```
libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
This change seems unrelated?
```

Change Summary:

Rebased and addressed issues.

Commits:

	Summary	ID
	Add a secondary id property to PurpleContactInfo This is meant to give the protocol to add a single additional identifier to a contact. Something like an XMPP resource or IRC ident.	10deb0c84811908967318dd236212836150fe8e0
	Add a secondary id property to PurpleContactInfo This is meant to give the protocol to add a single additional identifier to a contact. Something like an XMPP resource or IRC ident.	b91c8d560ce93d424fc5f9f9d8eedcc06c12f1f4

Diff:

	libpurple/purplecontactinfo.h
	libpurple/purplecontactinfo.c
	libpurple/tests/test_contact_info.c

Ship it!