Summary

Add online and federated properties to PurpleConversation

Review Request #2609 — Created Sept. 5, 2023 and submitted Sept. 12, 2023, 6:43 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This will allow user interfaces to more gracefully handle conversations with
disconnected accounts and offline conversations.

I didn't create a purple_conversation_new_federated as we don't have a purple_conversation_new yet. I'm waiting on both of those until PurpleConversation is a final type.

Testing Done

Compiled and ran the unit tests only. Writing unit tests for this right now would require a custom PurpleProtocol as well as a custom PurpleConnection and maybe more. So I skipped for the time being as this is pretty straight forward.

Commits

Summary	ID
Add online and federated properties to PurpleConversation This will allow user interfaces to more gracefully hand conversations with disconnected accounts and offline conversations.	56e3c432c30b843144a98708181e80031863cc2e

Issues

Description	From	Last Updated
s/can not/cannot/	QuLogic	Sept. 12, 2023, 5:24 a.m.
s/protocol/protocol,/ s/. Which/, which/	QuLogic	Sept. 12, 2023, 5:24 a.m.
No disconnecting from the old account? Or should this property be construct-only now?	QuLogic	Sept. 12, 2023, 5:25 a.m.
if(!connected) {	QuLogic	Sept. 12, 2023, 5:24 a.m.
s/one/on/	QuLogic	Sept. 12, 2023, 5:25 a.m.

Change Summary:: Fix typo.
Description:: ~
This will allow user interfaces to more gracefully hand conversations with
~
This will allow user interfaces to more gracefully handle conversations with
disconnected accounts and offline conversations.

I didn't create a purple_conversation_new_federated as we don't have a purple_conversation_new yet. I'm waiting on both of those until PurpleConversation is a final type.

libpurple/purpleconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/can not/cannot/
```
libpurple/purpleconversation.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/protocol/protocol,/

s/. Which/, which/
```

libpurple/purpleconversation.c (Diff revision 1)

The issue has been resolved. Show all issues

No disconnecting from the old account? Or should this property be construct-only now?

grim Sept. 12, 2023, 4:51 a.m.

You mean disconnecting the signal. I thought you meant handling when the account went offline :-D

grim Sept. 12, 2023, 4:52 a.m.

That said, we'll just make it construct only as nothing else should be setting this and if you're removing an account, it should remove all of the open conversations too.

libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
if(!connected) {
```
libpurple/purpleconversation.c (Diff revision 1)
The issue has been resolved. Show all issues
```
s/one/on/
```

Change Summary:

rebase and address issues.

Commits:

	Summary	ID
	Add online and federated properties to PurpleConversation This will allow user interfaces to more gracefully hand conversations with disconnected accounts and offline conversations.	17b76ac625539cef18a26c41b25925efa7174330
	Add online and federated properties to PurpleConversation This will allow user interfaces to more gracefully hand conversations with disconnected accounts and offline conversations.	56e3c432c30b843144a98708181e80031863cc2e

Diff:

Revision 2 (+434 -86)

Show changes

	ChangeLog.API
	libpurple/account.c
	libpurple/purpleconversation.h
	libpurple/purpleconversation.c

Ship it!

```
Ship It!
```

Status:: Completed

~		This will allow user interfaces to more gracefully hand conversations with
	~	This will allow user interfaces to more gracefully handle conversations with
		disconnected accounts and offline conversations.

		I didn't create a `purple_conversation_new_federated` as we don't have a `purple_conversation_new` yet. I'm waiting on both of those until `PurpleConversation` is a final type.