Summary

Add a conversation-changed signal to PurpleConversationManager

Review Request #2575 — Created Aug. 18, 2023 and submitted Aug. 18, 2023, 7:05 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

This signal propagate PurpleConversation::notify and supports details as well.

Testing Done

Ran the unit tests

Commits

Summary	ID
Add a conversation-changed signal to PurpleConversationManager This signal propagate PurpleConversation::notify and supports details as well.	1d0e50c80a3f22b54a52eaa29ee4e7fd0265c9d1

Issues

Description	From	Last Updated
Should change the conversation after this and confirm that the manager signal isn't called.	QuLogic	Aug. 18, 2023, 6:50 a.m.

libpurple/tests/test_conversation_manager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Should change the conversation after this and confirm that the manager signal isn't called.
```

Change Summary:

make sure our signals don't get propagated for unregistered conversations.

Commits:

	Summary	ID
	Add a conversation-changed signal to PurpleConversationManager This signal propagate PurpleConversation::notify and supports details as well.	ec640af74e42d9fe68f509ec0553ab5873ef4f9a
	Add a conversation-changed signal to PurpleConversationManager This signal propagate PurpleConversation::notify and supports details as well.	1d0e50c80a3f22b54a52eaa29ee4e7fd0265c9d1

Diff:

	libpurple/purpleconversationmanager.c
	libpurple/tests/test_conversation_manager.c

Ship it!