Summary

Add a basic status window to the IRCv3 protocol plugin

Review Request #2563 — Created Aug. 15, 2023 and submitted Aug. 15, 2023, 8:50 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17819

Depends On

Reviewers

Groups

pidgin

People

Description

There's a lot more to be tweaked in here, including adding an account action
to toggle visibility, but the basics work for now.

Testing Done

Connected to libera and my local ergo and checked it out!

Commits

Summary	ID
Add a basic status window to the IRCv3 protocol plugin There's a lot more to be tweaked in here, including adding an account action to toggle visibility, but the basics work for now.	5fedab43a58d49038df43558a7ea0dd8f1fc3f49

Files

Issues

Description	From	Last Updated
char	QuLogic	Aug. 15, 2023, 7:57 p.m.
Translate?	QuLogic	Aug. 15, 2023, 7:57 p.m.
Spacing seems off by one, but could be rbt.	QuLogic	Aug. 15, 2023, 7:57 p.m.
char	QuLogic	Aug. 15, 2023, 7:57 p.m.
char	QuLogic	Aug. 15, 2023, 7:57 p.m.
char	QuLogic	Aug. 15, 2023, 7:57 p.m.
Has this always been missing?	QuLogic	Aug. 15, 2023, 7:58 p.m.

libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
char
```
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Translate?
```
libpurple/protocols/ircv3/purpleircv3connection.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Spacing seems off by one, but could be rbt.
```
libpurple/protocols/ircv3/purpleircv3messagehandlers.c (Diff revision 1)
The issue has been resolved. Show all issues
```
char
```
libpurple/protocols/ircv3/purpleircv3parser.h (Diff revision 1)
The issue has been resolved. Show all issues
```
char
```
libpurple/protocols/ircv3/purpleircv3parser.c (Diff revision 1)
The issue has been resolved. Show all issues
```
char
```

libpurple/purpleconversation.c (Diff revision 1)

The issue has been dropped. Show all issues

Has this always been missing?

grim Aug. 15, 2023, 8:35 a.m.

Yeah, that method is private and in purpleprivate.h is is called by the subclasses instead of chaining up. I've been avoiding fixing it as we're going to fold PurpleIMConversation and PurpleChatConversation into PurpleConversation eventually.

Change Summary:

rebase and address issues

Commits:

	Summary	ID
	Add a basic status window to the IRCv3 protocol plugin There's a lot more to be tweaked in here, including adding an account action to toggle visibility, but the basics work for now.	1e1e2748da2dfbec745e6f9ab40ea4cf9f66efbb
	Add a basic status window to the IRCv3 protocol plugin There's a lot more to be tweaked in here, including adding an account action to toggle visibility, but the basics work for now.	5fedab43a58d49038df43558a7ea0dd8f1fc3f49

Diff:

Revision 2 (+418 -50)

Show changes

	libpurple/purpleconversation.c
	libpurple/protocols/ircv3/purpleircv3connection.h
	libpurple/protocols/ircv3/purpleircv3connection.c
	libpurple/protocols/ircv3/purpleircv3messagehandlers.h
	libpurple/protocols/ircv3/purpleircv3messagehandlers.c
	libpurple/protocols/ircv3/purpleircv3parser.h
	libpurple/protocols/ircv3/purpleircv3parser.c

Ship it!

```
Ship It!
```

Status:: Completed