Summary

Add some minor unit tests to PurpleConversationManager

Review Request #2561 — Created Aug. 15, 2023 and submitted Aug. 15, 2023, 7:27 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

For some reason we didn't have any unit tests for PurpleConversationManager so
this just adds a register/unregister test to make sure the basics are working.

I kept this brief because I already found a number of issues, and I'm sure we'll find more as we add more tests.

Testing Done

Ran the tests.

Commits

Summary	ID
Add some minor unit tests to PurpleConversationManager For some reason we didn't have any unit tests for PurpleConversationManager so this just adds a register/unregister test to make sure the basics are working.	8f5e4410e14872622da4f526322edd0896290ed2

Issues

Description	From	Last Updated
Any reason not to be guint like the previous test where that was added?	QuLogic	Aug. 15, 2023, 5:32 a.m.
s/contact/conversation/	QuLogic	Aug. 15, 2023, 5:32 a.m.

libpurple/tests/test_conversation_manager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Any reason not to be guint like the previous test where that was added?
```
libpurple/tests/test_conversation_manager.c (Diff revision 1)
The issue has been resolved. Show all issues
```
s/contact/conversation/
```

Change Summary:

address issues

Commits:

	Summary	ID
	Add some minor unit tests to PurpleConversationManager For some reason we didn't have any unit tests for PurpleConversationManager so this just adds a register/unregister test to make sure the basics are working.	bd5d88afc944aa9111886ea3629d3274d92e33d5
	Add some minor unit tests to PurpleConversationManager For some reason we didn't have any unit tests for PurpleConversationManager so this just adds a register/unregister test to make sure the basics are working.	8f5e4410e14872622da4f526322edd0896290ed2

Diff:

Revision 2 (+242 -8)

Show changes

	libpurple/purpleconversation.c
	libpurple/tests/meson.build
	libpurple/tests/test_conversation_manager.c

Ship it!

```
Ship It!
```

Status:: Completed