Fix some scan-build issues

Review Request #2554 — Created Aug. 8, 2023 and submitted

Information

pidgin/pidgin
default

Reviewers

  • In finch/gntaccount.c, scan-build thinks that dialog->account may change
    between the two places it is used; this is not the case, but easiest to
    placate it by using a common variable.
  • In finch/gntblist.c, comment out more code to limit dead stores.
  • In libpurple/mediamanager.c and pidgin/gtkrequest.c, a non-NULL
    initializer is used on a variable that is replaced later by the same thing,
    so just initialize to NULL instead.

Compiled with ninja scan-build.

Summary ID
Fix some scan-build issues
* In `finch/gntaccount.c`, scan-build thinks that `dialog->account` may change between the two places it is used; this is not the case, but easiest to placate it by using a common variable. * In `finch/gntblist.c`, comment out more code to limit dead stores. * In `libpurple/mediamanager.c` and `pidgin/gtkrequest.c`, a non-NULL initializer is used on a variable that is replaced later by the same thing, so just initialize to NULL instead.
dcc545eaed4661877e40078f4e34ecc30cd82a5f
grim
  1. Ship It!
  2. Great work! Thanks!!

  3. 
      
grim
Review request changed
Status:
Completed