Summary

Remove a bunch of dead code from gtkconv

Review Request #2538 — Created Aug. 1, 2023 and submitted Aug. 8, 2023, 4:24 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

I tried my best to get the keybindings working, but none of them did.

Testing Done

Compiled and tried all sorts of keybindings in the history and input. I had a message selected in the history and was able to type in the input without any of that old code.

Commits

Summary	ID
Remove a bunch of dead code from gtkconv I tried my best to get the keybindings working, but none of them did.	8b89f3272558a585ccaf6e376b5dc38295ba5773

Issues

Description	From	Last Updated
Seems like this is missing from the ChangeLog.API	QuLogic	Aug. 8, 2023, 4:06 a.m.
Seems unrelated to code deletion; not sure if this was intended to be here.	QuLogic	Aug. 8, 2023, 4:06 a.m.

doc/reference/pidgin/signals_gtkconv.md (Diff revision 1)
The issue has been resolved. Show all issues
```
Seems like this is missing from the ChangeLog.API
```

pidgin/pidgindisplaywindow.c (Diff revision 1)

The issue has been resolved. Show all issues

Seems unrelated to code deletion; not sure if this was intended to be here.

grim Aug. 8, 2023, 3:59 a.m.

I was testing stuff and forgot to remove it, good catch!

Change Summary:

address issues

Commits:

	Summary	ID
	Remove a bunch of dead code from gtkconv I tried my best to get the keybindings working, but none of them did.	42633f155e08f5ce2cc50eaac3bda0d2c0af744e
	Remove a bunch of dead code from gtkconv I tried my best to get the keybindings working, but none of them did.	8b89f3272558a585ccaf6e376b5dc38295ba5773

Diff:

Revision 2 (+8 -1232)

Show changes

	ChangeLog.API
	doc/reference/pidgin/signals_gtkconv.md
	pidgin/gtkconv.h
	pidgin/gtkconv.c

Ship it!

```
Ship It!
```

Status:: Completed