Summary

Add PurpleProtocolRoster for managing server side rosters

Review Request #2517 — Created July 17, 2023 and submitted July 18, 2023, 5:41 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Add PurpleProtocolRoster for managing server side rosters

Testing Done

Ran the unit tests.

Commits

Summary	ID
Add PurpleProtocolRoster for managing server side rosters	22192b238243d36b371ff4fc7b1a3aa5d4e8f660

Issues

Description	From	Last Updated
s/add/update	ivanhoe	July 18, 2023, 5:06 a.m.
s/add/remove	ivanhoe	July 18, 2023, 5:06 a.m.
memory leak	ivanhoe	July 18, 2023, 5:10 a.m.
memory leak	ivanhoe	July 18, 2023, 5:10 a.m.
memory leak	ivanhoe	July 18, 2023, 5:10 a.m.
A	QuLogic	July 18, 2023, 5:30 a.m.
otherwise	QuLogic	July 18, 2023, 5:30 a.m.
A	QuLogic	July 18, 2023, 5:30 a.m.
otherwise	QuLogic	July 18, 2023, 5:30 a.m.
A	QuLogic	July 18, 2023, 5:30 a.m.
otherwise	QuLogic	July 18, 2023, 5:30 a.m.
No cast for data again (and below)?	QuLogic	July 18, 2023, 5:39 a.m.

libpurple/purpleprotocolroster.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/add/update
```
libpurple/purpleprotocolroster.h (Diff revision 1)
The issue has been resolved. Show all issues
```
s/add/remove
```
libpurple/tests/test_protocol_roster.c (Diff revision 1)
The issue has been resolved. Show all issues
```
memory leak
```
libpurple/tests/test_protocol_roster.c (Diff revision 1)
The issue has been resolved. Show all issues
```
memory leak
```
libpurple/tests/test_protocol_roster.c (Diff revision 1)
The issue has been resolved. Show all issues
```
memory leak
```

Change Summary:

Address issues

Commits:

	Summary	ID
	Add PurpleProtocolRoster for managing server side rosters	3aa895884fc252116c412c9ad0a6f88582c7fca1
	Add PurpleProtocolRoster for managing server side rosters	105f10317599d1912300ebef4d37affaa9c99fc9

Diff:

Revision 2 (+1672)

Show changes

	libpurple/meson.build
	libpurple/purpleprotocolroster.h
	libpurple/purpleprotocolroster.c
	libpurple/tests/meson.build
	libpurple/tests/test_protocol_roster.c

Ship it!

```
Ship It!
```

libpurple/purpleprotocolroster.h (Diff revision 2)
The issue has been resolved. Show all issues
```
A
```
libpurple/purpleprotocolroster.h (Diff revision 2)
The issue has been resolved. Show all issues
```
otherwise
```
libpurple/purpleprotocolroster.h (Diff revision 2)
The issue has been resolved. Show all issues
```
A
```
libpurple/purpleprotocolroster.h (Diff revision 2)
The issue has been resolved. Show all issues
```
otherwise
```
libpurple/purpleprotocolroster.h (Diff revision 2)
The issue has been resolved. Show all issues
```
A
```
libpurple/purpleprotocolroster.h (Diff revision 2)
The issue has been resolved. Show all issues
```
otherwise
```

Change Summary:

fix my dumb typos, sorry.

Commits:

	Summary	ID
	Add PurpleProtocolRoster for managing server side rosters	105f10317599d1912300ebef4d37affaa9c99fc9
	Add PurpleProtocolRoster for managing server side rosters	9287308b25070e6ef3658a6d86794dacfe75cbbb

Diff:

Revision 3 (+1672)

Show changes

	libpurple/meson.build
	libpurple/purpleprotocolroster.h
	libpurple/purpleprotocolroster.c
	libpurple/tests/meson.build
	libpurple/tests/test_protocol_roster.c

libpurple/tests/test_protocol_roster.c (Diff revision 2)
The issue has been resolved. Show all issues
```
No cast for data again (and below)?
```

Change Summary:

now with less casts's!!

Commits:

	Summary	ID
	Add PurpleProtocolRoster for managing server side rosters	9287308b25070e6ef3658a6d86794dacfe75cbbb
	Add PurpleProtocolRoster for managing server side rosters	22192b238243d36b371ff4fc7b1a3aa5d4e8f660

Diff:

Revision 4 (+1672)

Show changes

	libpurple/meson.build
	libpurple/purpleprotocolroster.h
	libpurple/purpleprotocolroster.c
	libpurple/tests/meson.build
	libpurple/tests/test_protocol_roster.c

Ship it!

```
Ship It!
```

Status:: Completed