Summary

Add purple_tags_get_all_with_name

Review Request #2503 — Created July 7, 2023 and submitted July 14, 2023, 4:22 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

I realized I needed this when I started porting XMPP to the new Contact API. I
need to be able to get a list of all the groups that a contact is in so I can
updated them appropriately but we didn't have the api for it. This is something
that other protocols will need to do as well so here's the API.

Testing Done

Ran the unit tests.

Commits

Summary	ID
Add purple_tags_get_all_with_name I realized I needed this when I started porting XMPP to the new Contact API. I need to be able to get a list of all the groups that a contact is in so I can updated them appropriately but we didn't have the api for it. This is something that other protocols will need to do as well so here's the API.	04b3c87484391889153f92b8711153171120f6b9

Issues

Description	From	Last Updated
We should also check whether the value pointer is inside the tag string and not outside after adding name_len to …	belgin	July 14, 2023, 2:43 p.m.

libpurple/purpletags.c (Diff revision 1)

The issue has been dropped. Show all issues

We should also check whether the value pointer is inside the tag string and not outside after adding name_len to it, since we're dereferencing it.

grim July 13, 2023, 11:12 p.m.

A tag is a string comprised of a name and an options value. For example the tag display:1 has a name of display and a value of 1. Likewise, the tag display: has a name of display and an empty value (the *value == ':' case), and the tag display has a name of display and no value (the (*value == '\0') case).

belgin July 14, 2023, 2:44 p.m.

I see the case I mentioned is not possible because of the g_str_has_prefix function call above.

Ship it!

```
Ship It!
```

Ship it!

```
Ship It!
```

Status:: Completed