Summary

Add gettext support

Review Request #2489 — Created June 29, 2023 and submitted June 29, 2023, 7:01 a.m.

Information

Owner

grim

Repository

hasl/hasl

Branch

default

Bugs

HASL-4

Depends On

Reviewers

Groups

pidgin

People

Description

Add gettext support

Testing Done

Ran ninja hasl-pot and verfied it generated $topsrcdir/po/hasl.pot and that it had the entries we expected.
Also disabled nls and verified that the hasl-pot target didn't exist and that we got the warning in the summaries.

Also ran from the $topsrcdir as po/update-potfiles.sh and it output the correct values as well.

Commits

Summary	ID
Add gettext support	ae1aa27e79bca048eba27703b9f8dcaab10aee5a

Issues

Description	From	Last Updated
This probably assumes that update-potfiles.sh is run while in the po directory, but might break if run as ./po/update-potfiles.sh. Might …	QuLogic	June 29, 2023, 7 a.m.

po/update-potfiles.sh (Diff revision 1)

The issue has been resolved. Show all issues

This probably assumes that update-potfiles.sh is run while in the po directory, but might break if run as ./po/update-potfiles.sh. Might want to cd $(dirname $0) first, or something like that which shellcheck is happy with.

Testing Done:

		Ran `ninja hasl-pot` and verfied it generated `$topsrcdir/po/hasl.pot` and that it had the entries we expected.
		Also disabled `nls` and verified that the `hasl-pot` target didn't exist and that we got the warning in the summaries.
	+
	+	Also ran from the `$topsrcdir` as `po/update-potfiles.sh` and it output the correct values as well.

Commits:

	Summary	ID
	Add gettext support	1401d2067f1e651c6cb380a8415fafcd44c4aac2
	Add gettext support	ba7ec8152cf9740a8c2c55160176d5547dfb1c2b

Diff:

Revision 2 (+116 -12)

Show changes

	meson.build
	meson_options.txt
	hasl/haslcontext.c
	hasl/haslmechanismplain.c
	po/LINGUAS
	po/POTFILES
	po/meson.build
	po/update-potfiles.sh

Change Summary:

let the turtles handle hasl-pot as well

Commits:

	Summary	ID
	Add gettext support	ba7ec8152cf9740a8c2c55160176d5547dfb1c2b
	Add gettext support	ae1aa27e79bca048eba27703b9f8dcaab10aee5a

Diff:

Revision 3 (+118 -14)

Show changes

	meson.build
	meson_options.txt
	hasl/haslcontext.c
	hasl/haslmechanismplain.c
	po/LINGUAS
	po/POTFILES
	po/meson.build
	po/update-potfiles.sh

Ship it!

```
Ship It!
```

Status:: Completed