Summary

Port the demo protocol plugin to contacts

Review Request #2432 — Created April 11, 2023 and submitted April 11, 2023, 11:12 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2431~~

Reviewers

Groups

pidgin

People

Description

Port the demo protocol plugin to contacts

Testing Done

Deleted the old blist.xml from my XDG_CONFIG_HOME and verified that I only got the new contacts and verified that they were not stored back to blist.xml.

Commits

Summary	ID
Port the demo protocol plugin to contacts	e8dd63649c84fb0aec9180cf319aaa06b95c1d5f

Issues

Description	From	Last Updated
char	QuLogic	April 11, 2023, 10:39 p.m.
This is 2.26+ which is fine, but we don't specify a minimum yet.	QuLogic	April 11, 2023, 10:39 p.m.
Is there some other key we'll be putting in here, or can we make the contacts list the top-level object?	QuLogic	April 11, 2023, 10:40 p.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Port the demo protocol plugin to contacts	f7bc4d7f2560f9677bcafd5554c80c1bf7378093
	Port the demo protocol plugin to contacts	558a1efdef759c3222ff7c5ebddbb99cd5499205

Diff:

Revision 2 (+560 -408)

Show changes

	libpurple/protocols/demo/purpledemocontacts.c
	libpurple/protocols/demo/resources/contacts.json

libpurple/protocols/demo/purpledemocontacts.c (Diff revision 2)
The issue has been resolved. Show all issues
```
char
```
libpurple/protocols/demo/purpledemocontacts.c (Diff revision 2)
The issue has been resolved. Show all issues
```
This is 2.26+ which is fine, but we don't specify a minimum yet.
```

libpurple/protocols/demo/resources/contacts.json (Diff revision 2)

The issue has been resolved. Show all issues

Is there some other key we'll be putting in here, or can we make the contacts list the top-level object?

Change Summary:

address issues

Commits:

	Summary	ID
	Port the demo protocol plugin to contacts	558a1efdef759c3222ff7c5ebddbb99cd5499205
	Port the demo protocol plugin to contacts	e8dd63649c84fb0aec9180cf319aaa06b95c1d5f

Diff:

Revision 3 (+532 -416)

Show changes

	meson.build
	libpurple/protocols/demo/purpledemocontacts.c
	libpurple/protocols/demo/resources/contacts.json

Ship it!

```
Ship It!
```

Status:: Completed