Summary

Add the presence primitive and idle time to the contact list

Review Request #2391 — Created March 24, 2023 and submitted March 30, 2023, 4:21 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

The idle time is getting overwritten by something right now which is unrelated
and will be addressed separately.

Testing Done

Connected the demo protocol plugin and looked at the contact list.

Commits

Summary	ID
Add the presence primitive and idle time to the contact list The idle time is getting overwritten by something right now which is unrelated and will be addressed separately.	69702e419730613d0632e3753f00a753f8327106

Files

Issues

Description	From	Last Updated
So you probably don't get idle in the presence because this binding is only on the presence. Idle time is …	QuLogic	March 24, 2023, 5:05 a.m.

pidgin/resources/ContactList/widget.ui (Diff revision 1)

The issue has been dropped. Show all issues

So you probably don't get idle in the presence because this binding is only on the presence.

Idle time is a property on the presence, but it's only looked up in the closure callback, and not mentioned in the XML here, so watches for changes are only made on the presence.

grim March 24, 2023, 4:59 a.m.

I put g_warnings in the closure and saw it called three times for the same presence. Why three times, I don't know, but the third time the idle-time property was NULL'd out. This lead me to reason that something was incorrectly clearing the idle state which is why I said it's unrelated.

QuLogic March 24, 2023, 5:05 a.m.

OK, I can see it in a traceback, with some kind of property notification loop, but haven't figured out where it's going through yet.

grim March 24, 2023, 6:02 a.m.

Yeah that's why i was like "that's a tomorrow problem" :-D

Ship it!

```
Ship It!
```

Status:: Completed