Summary

Split account display from chooser into its own widget

Review Request #2360 — Created March 19, 2023 and submitted March 20, 2023, 10:26 p.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Blocks

2361

Reviewers

Groups

pidgin

People

Description

This will allow re-using it elsewhere when we need to display the account.

Testing Done

Compiled and opened Add a Buddy dialog, Room List, etc. that used the chooser.

Commits

Summary	ID
Split account display from chooser into its own widget	0182e14f9db7bdb299b7cb20237f3c8f6ed77190

Issues

Description	From	Last Updated
Needs new file header, the first few lines aren't right.	grim	March 20, 2023, 10:25 p.m.
we don't typically have a newline here for whatever reason	grim	March 20, 2023, 10:25 p.m.
I wonder if we should use name_for_display here instead of username and alias, but we're skipping display-name as well right …	grim	March 20, 2023, 10:24 p.m.
I thought passing NULL to set_text causes a crash?	grim	March 20, 2023, 10:24 p.m.
doc comment	grim	March 20, 2023, 10:25 p.m.

pidgin/pidginaccountdisplay.h (Diff revision 1)
The issue has been resolved. Show all issues
```
Needs new file header, the first few lines aren't right.
```
pidgin/pidginaccountdisplay.h (Diff revision 1)
The issue has been resolved. Show all issues
```
we don't typically have a newline here for whatever reason
```

pidgin/pidginaccountdisplay.c (Diff revision 1)

The issue has been dropped. Show all issues

I wonder if we should use name_for_display here instead of username and alias, but we're skipping display-name as well right now and adding that would make this REALLY long..

QuLogic March 20, 2023, 10:20 p.m.

We can probably tweak what gets displayed here, which I expected to do some of once everything is using it, possibly with a "compact" property or similar.

grim March 20, 2023, 10:25 p.m.
```
oh that's an interesting idea.
```

pidgin/pidginaccountdisplay.c (Diff revision 1)

if/when we implement the missing prpl we should use it's icon here.

pidgin/pidginaccountdisplay.c (Diff revision 1)

The issue has been dropped. Show all issues

I thought passing NULL to set_text causes a crash?

QuLogic March 20, 2023, 10:20 p.m.

I think that's only for GtkEditable; the previous code only had the check because of the sorter, not the labels.

GtkLabel is NULL-safe: https://gitlab.gnome.org/GNOME/gtk/-/blob/4.0.0/gtk/gtklabel.c#L1713

pidgin/pidginaccountdisplay.c (Diff revision 1)
The issue has been resolved. Show all issues
```
doc comment
```

Change Summary:

Handle review comments.

Commits:

	Summary	ID
	Split account display from chooser into its own widget	c4cd41e0e4b7b15da3a706b0db432c85794495af
	Split account display from chooser into its own widget	0182e14f9db7bdb299b7cb20237f3c8f6ed77190

Diff:

Revision 2 (+642 -138)

Show changes

	pidgin/meson.build
	pidgin/pidginaccountchooser.c
	pidgin/pidginaccountdisplay.h
	pidgin/pidginaccountdisplay.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/Accounts/chooser.ui
	pidgin/resources/Accounts/display.ui

Ship it!

```
Ship It!
```
```
Great work, thanks!!
```

Status:: Completed