Summary

Add a PurpleRequestField:valid property and is_valid vfunc

Review Request #2346 — Created March 14, 2023 and submitted March 17, 2023, 1:44 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

~~2345~~

Blocks

2349, 2348

Reviewers

Groups

pidgin

People

Description


Add a PurpleRequestField:valid property and is_valid vfunc.
Add a GDestroyNotify parameter for the validator data, and document the callback.
Correct the property notification in purple_request_field_bool_set_value.

Testing Done

Compiled and ran ninja test

Commits

Summary	ID
Add a PurpleRequestField:valid property and is_valid vfunc Additionally, * Add `GDestroyNotify` parameter to `purple_request_field_set_validator`. * Fix property notification from `purple_request_field_bool_set_value`.	705089d4ed02d786325f783e0f4a45fa4e6ed64f

Issues

Description	From	Last Updated
%NULL	grim	March 17, 2023, 1:37 a.m.
%NULL	grim	March 17, 2023, 1:38 a.m.
should we be freezing here?	grim	March 17, 2023, 1:38 a.m.
mark for translation	grim	March 17, 2023, 1:38 a.m.
Should we be freezing here?	grim	March 17, 2023, 1:39 a.m.
freeze notify?	grim	March 17, 2023, 1:39 a.m.
freeze notify?	grim	March 17, 2023, 1:40 a.m.
should be marked for translation	grim	March 17, 2023, 1:40 a.m.
should be marked for translation	grim	March 17, 2023, 1:40 a.m.
freeze?	grim	March 17, 2023, 1:40 a.m.
Once the int validation strings are marked for translation, we'll need to add an environment to this test to set …	grim	March 17, 2023, 1:41 a.m.

libpurple/purplerequestfield.h (Diff revision 1)
The issue has been resolved. Show all issues
```
%NULL
```
libpurple/purplerequestfield.h (Diff revision 1)
The issue has been resolved. Show all issues
```
%NULL
```
libpurple/purplerequestfield.c (Diff revision 1)
The issue has been dropped. Show all issues
```
should we be freezing here?
```
1. QuLogic March 16, 2023, 6:52 a.m.
  No point here; the other property is going away soon.
libpurple/purplerequestfield.c (Diff revision 1)
The issue has been resolved. Show all issues
```
mark for translation
```
libpurple/request/purplerequestfieldaccount.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Should we be freezing here?
```
libpurple/request/purplerequestfieldbool.c (Diff revision 1)
The issue has been resolved. Show all issues
```
freeze notify?
```
libpurple/request/purplerequestfieldchoice.c (Diff revision 1)
The issue has been resolved. Show all issues
```
freeze notify?
```
libpurple/request/purplerequestfieldint.c (Diff revision 1)
The issue has been resolved. Show all issues
```
should be marked for translation
```
libpurple/request/purplerequestfieldint.c (Diff revision 1)
The issue has been resolved. Show all issues
```
should be marked for translation
```
libpurple/request/purplerequestfieldint.c (Diff revision 1)
The issue has been resolved. Show all issues
```
freeze?
```

libpurple/tests/test_request_field.c (Diff revision 1)

The issue has been dropped. Show all issues

Once the int validation strings are marked for translation, we'll need to add an environment to this test to set LANG=C.

I tried finding a way to do this at run time, but google wasn't coming up with anything. It might be as easy as just a g_setenv before initializing gettext, but actually maybe we don't need to do any of this because our tests don't initialize gettext?

Change Summary:

Add freezes, translation, and %.

Commits:

	Summary	ID
	Add a PurpleRequestField:valid property and is_valid vfunc Additionally, * Add `GDestroyNotify` parameter to `purple_request_field_set_validator`. * Fix property notification from `purple_request_field_bool_set_value`.	31096454cb8f98777f2c13174d87f2b243efe28c
	Add a PurpleRequestField:valid property and is_valid vfunc Additionally, * Add `GDestroyNotify` parameter to `purple_request_field_set_validator`. * Fix property notification from `purple_request_field_bool_set_value`.	705089d4ed02d786325f783e0f4a45fa4e6ed64f

Diff:

Revision 2 (+478 -70)

Show changes

	libpurple/purplerequestfield.h
	libpurple/purplerequestfield.c
	libpurple/protocols/demo/purpledemoprotocolactions.c
	libpurple/request/purplerequestfieldaccount.c
	libpurple/request/purplerequestfieldbool.c
	libpurple/request/purplerequestfieldchoice.c
	libpurple/request/purplerequestfieldint.c
	libpurple/request/purplerequestfieldlist.c
	4 more

Ship it!

```
Ship It!
```
```
Great work, thanks!!
```

Status:: Completed