Summary

Clean up the null checking in pidgin_contact_list_avatar_cb

Review Request #2243 — Created Feb. 18, 2023 and submitted Feb. 19, 2023, 10:13 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Somehow I made a mess of the NULL handling here so this just cleans it all up.

Testing Done

Navigated away and back to the contact list a few times and verified the warnings were gone.

Commits

Summary	ID
Fix another warning when navigating away from the contact list Not sure how I missed this in the previous patch, but again, the closures get called when we're emptying rows, so our items are NULL and we need to account for that.	2a7fac5ecdf361adc2b3660a2312f3998e988501

Summary:

Fix another warning when navigating away from the contact list

Clean up the null checking in pidgin_contact_list_avatar_cb

Description:

~		Not sure how I missed this in the previous patch, but again, the closures get
	~	Somehow I made a mess of the `NULL` handling here so this just cleans it all up.
-		called when we're emptying rows, so our items are NULL and we need to account
-		for that.

Commits:

	Summary	ID
	Fix another warning when navigating away from the contact list Not sure how I missed this in the previous patch, but again, the closures get called when we're emptying rows, so our items are NULL and we need to account for that.	ec8a558f919975aadcfc9e98a0d55d6ec1fdba60
	Fix another warning when navigating away from the contact list Not sure how I missed this in the previous patch, but again, the closures get called when we're emptying rows, so our items are NULL and we need to account for that.	2a7fac5ecdf361adc2b3660a2312f3998e988501

Diff:

Ship it!