Summary

Display the preferences window as a singleton from the application

Review Request #2242 — Created Feb. 18, 2023 and submitted Feb. 22, 2023, 3:42 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This is how we handle displaying other dialogs and apparently the preferences
window just got missed. We also make it transient for whatever window is active
which means it won't fill an entire cell in a tiling window manager.

Testing Done

Opened the preferences dialog in i3 and verified it was no longer a full tile and that everything worked as expected.

Commits

Summary	ID
Display the preferences window as a singleton from the application This is how we handle displaying other dialogs and apparently the preferences window just got missed. We also make it transient for whatever window is active which means it won't fill an entire cell in a tiling window manager.	127ac6306b96c7102540e87845cf4e108c5dba93

Issues

Description	From	Last Updated
No longer unused.	QuLogic	Feb. 22, 2023, 3:18 a.m.

pidgin/pidginapplication.c (Diff revision 1)
The issue has been resolved. Show all issues
```
No longer unused.
```

Change Summary:

remove a G_GNUC_UNUSED which is no longer valid.

Commits:

	Summary	ID
	Display the preferences window as a singleton from the application This is how we handle displaying other dialogs and apparently the preferences window just got missed. We also make it transient for whatever window is active which means it won't fill an entire cell in a tiling window manager.	403de7ec0e65caa5a77066a0ec38feb626ef1ad1
	Display the preferences window as a singleton from the application This is how we handle displaying other dialogs and apparently the preferences window just got missed. We also make it transient for whatever window is active which means it won't fill an entire cell in a tiling window manager.	127ac6306b96c7102540e87845cf4e108c5dba93

Diff:

Revision 2 (+46 -76)

Show changes

	ChangeLog.API
	pidgin/pidginapplication.c
	pidgin/prefs/pidginprefs.h
	pidgin/prefs/pidginprefs.c
	pidgin/resources/Prefs/prefs.ui

Ship it!

```
Ship It!
```

Status:: Completed

pidgin/pidginapplication.c (Diff revision 1)