Summary

Avoid some GWarnings when selecting away from contacts

Review Request #2233 — Created Feb. 10, 2023 and submitted Feb. 18, 2023, 1:40 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

When we move the DisplayWindow to GtkListView, we moved to using an AdwBin as
the container widget and just set the child to what should be displayed. When
this happens to a ListView, each item gets deleted and for some reason the
bound property closures in the factory get called with an item that is set to
NULL. So if we get passed NULL, we just need to bail.

Testing Done

Ran under gdb with G_DEBUG=fatal-warnings and verified that it didn't break when I switched the display window from contacts to conversations.

Commits

Summary	ID
Avoid some GWarnings when selecting away from contacts When we move the DisplayWindow to GtkListView, we moved to using an AdwBin as the container widget and just set the child to what should be displayed. When this happens to a ListView, each item gets deleted and for some reason the bound property closures in the factory get called with an item that is set to NULL. So if we get passed NULL, we just need to bail.	b41ca38c3bc2095ae41e9fab8bfe7f9d61aff456

Summary

Avoid some GWarnings when selecting away from contacts

When we move the DisplayWindow to GtkListView, we moved to using an AdwBin as the container widget and just set the child to what should be displayed. When this happens to a ListView, each item gets deleted and for some reason the bound property closures in the factory get called with an item that is set to NULL. So if we get passed NULL, we just need to bail.

b41ca38c3bc2095ae41e9fab8bfe7f9d61aff456

Ship it!

```
Ship It!
```

Status:: Completed