Summary

Export Account::error

Review Request #2216 — Created Jan. 27, 2023 and submitted Feb. 8, 2023, 3 p.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

I can't think of a good reason why we shouldn't expose the error property on
Accounts. But I would like to be able to set the error from the UI when there
is an error in the settings for example.

Testing Done

Built the docs, ran the tests, used the prune connection action in the demo protocol plugin and verified everything was still working.

Commits

Summary	ID
Export Account::error I can't think of a good reason why we shouldn't expose the error property on Accounts. But I would like to be able to set the error from the UI when there is an error in the settings for example.	1201b95b170b93e28bec8d532aebafe88a55c533

Issues

Description	From	Last Updated
Probably should say now "The account whose error state should be set" or something like that.	ivanhoe	Feb. 8, 2023, 6:56 a.m.

libpurple/account.h (Diff revision 1)

The issue has been resolved. Show all issues

Probably should say now "The account whose error state should be set" or something like that.

grim Feb. 8, 2023, 12:45 a.m.

Nice catch, clearly I missed this part :-D

Change Summary:

rebase and fix doc comment

Commits:

	Summary	ID
	Export Account::error I can't think of a good reason why we shouldn't expose the error property on Accounts. But I would like to be able to set the error from the UI when there is an error in the settings for example.	6374ce8efb35c8ec4d5bfbffd7437859b0f4abf4
	Export Account::error I can't think of a good reason why we shouldn't expose the error property on Accounts. But I would like to be able to set the error from the UI when there is an error in the settings for example.	1201b95b170b93e28bec8d532aebafe88a55c533

Diff:

Revision 2 (+132 -132)

Show changes

	libpurple/account.h
	libpurple/account.c
	libpurple/accounts.c
	libpurple/purpleaccountmanager.c
	libpurple/purpleprivate.h
	pidgin/pidginaccountrow.c

Ship it!

```
Ship It!
```

Status:: Completed