Summary

Add purple_strmatches and move purple_person_matches and purple_contact_info_matches to it

Review Request #2212 — Created Jan. 24, 2023 and submitted Feb. 18, 2023, 1:36 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

PIDGIN-17737

Depends On

~~2211~~

Reviewers

Groups

pidgin

People

Description

This uses a naive algorithm to do fuzzy matching but appears to be good enough
for now. We can look at something more complicated later if the performance of
this is bad enough.

Testing Done

Ran the unit tests and tested the search in the contact list.

Commits

Summary	ID
Add purple_strmatches and move purple_person_matches and purple_contact_info_matches to it This uses a naive algorithm to do fuzzy matching but appears to be good enough for now. We can look at something more complicated later if the performance of this is bad enough.	33161ad239dd08b3e643313254d10dfb71a9a055

Files

Change Summary:

don't match id's because all of a sudden you type af and match things that you don't expect to match because the underlying sha256 hash in the id matches that..

Commits:

	Summary	ID
	Add purple_strmatches and move purple_person_matches and purple_contact_info_matches to it This uses a naive algorithm to do fuzzy matching but appears to be good enough for now. We can look at something more complicated later if the performance of this is bad enough.	f39827443477b5c11774ec58ca75fd7a3ea472b9
	Add purple_strmatches and move purple_person_matches and purple_contact_info_matches to it This uses a naive algorithm to do fuzzy matching but appears to be good enough for now. We can look at something more complicated later if the performance of this is bad enough.	da88fa40ae33b7f496e552104b4eba708f3a1692

Diff:

Revision 2 (+326 -20)

Show changes

	libpurple/purplecontactinfo.h
	libpurple/purplecontactinfo.c
	libpurple/purpleperson.c
	libpurple/util.h
	libpurple/util.c
	libpurple/tests/meson.build
	libpurple/tests/test_str.c

Change Summary:

rebased

Commits:

	Summary	ID
	Add purple_strmatches and move purple_person_matches and purple_contact_info_matches to it This uses a naive algorithm to do fuzzy matching but appears to be good enough for now. We can look at something more complicated later if the performance of this is bad enough.	da88fa40ae33b7f496e552104b4eba708f3a1692
	Add purple_strmatches and move purple_person_matches and purple_contact_info_matches to it This uses a naive algorithm to do fuzzy matching but appears to be good enough for now. We can look at something more complicated later if the performance of this is bad enough.	33161ad239dd08b3e643313254d10dfb71a9a055

Diff:

Revision 3 (+326 -20)

Show changes

	libpurple/purplecontactinfo.h
	libpurple/purplecontactinfo.c
	libpurple/purpleperson.c
	libpurple/util.h
	libpurple/util.c
	libpurple/tests/meson.build
	libpurple/tests/test_str.c

Ship it!

```
Ship It!
```

Status:: Completed