Summary

Create a new PidginContactList widget that shows the PurplePersons that PurpleContactManager is tracking

Review Request #2146 — Created Dec. 16, 2022 and submitted Jan. 13, 2023, 7:01 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

This has a few caveats with it.

First of all, we're using closures just to make stuff work for now since we can't bind properties. A side effect of that, is that the list won't update when the property changes on the Person/Contact. That will be fixed later as we clean up a bunch of stuff like porting PidginAvatar to PurpleAvatar.

For the text, I skipped the status messages and idle times for now because they won't update as their not bound properties and will require cleaning up the status API to make that work at all.

Person/Contact don't have a name-for-display property, so right now that's implemented as a closure as well.

I also skipped search and sorting for now, to keep the review size small.

Regardless, this looks pretty snazzy if I do say so!

Testing Done

Ran the program and verified stuff was working.

Commits

Summary	ID
Create a new PidginContactList widget that shows the PurplePersons that PurpleContactManager is tracking	7c826d697a2e8dfe17670729daa739a49e77ad81

Files

Issues

Description	From	Last Updated
Should refresh for /r/2151, I think?	QuLogic	Jan. 6, 2023, 8:36 a.m.
Bit of an odd indent; I think we usually drop these nested ones to column 0.	QuLogic	Jan. 6, 2023, 8:34 a.m.
s/than/that/	QuLogic	Jan. 6, 2023, 8:34 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Create a new PidginContactList widget that shows the PurplePersons that PurpleContactManager is tracking	0d981eaf1ad22a56b4fd05f1585f0fa954642092
	Create a new PidginContactList widget that shows the PurplePersons that PurpleContactManager is tracking	ff33873155a6eb40526ccb48b57d8d99e0d5e9a6

Diff:

Revision 2 (+572 -10)

Show changes

	meson.build
	libpurple/purplecontactmanager.c
	pidgin/meson.build
	pidgin/pidgincontactlist.h
	pidgin/pidgincontactlist.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/ContactList/widget.ui
	pidgin/resources/Display/window.ui

The issue has been resolved. Show all issues
```
Should refresh for /r/2151, I think?
```
pidgin/resources/ContactList/widget.ui (Diff revision 2)
The issue has been resolved. Show all issues
```
Bit of an odd indent; I think we usually drop these nested ones to column 0.
```
pidgin/resources/ContactList/widget.ui (Diff revision 2)
The issue has been resolved. Show all issues
```
s/than/that/
```

Change Summary:

rebase, address issues, and replace a closure with some expressions

Commits:

	Summary	ID
	Create a new PidginContactList widget that shows the PurplePersons that PurpleContactManager is tracking	ff33873155a6eb40526ccb48b57d8d99e0d5e9a6
	Create a new PidginContactList widget that shows the PurplePersons that PurpleContactManager is tracking	7c826d697a2e8dfe17670729daa739a49e77ad81

Diff:

Revision 3 (+542 -10)

Show changes

	meson.build
	libpurple/purplecontactmanager.c
	pidgin/meson.build
	pidgin/pidgincontactlist.h
	pidgin/pidgincontactlist.c
	pidgin/resources/pidgin.gresource.xml
	pidgin/resources/ContactList/widget.ui
	pidgin/resources/Display/window.ui

libpurple/purplecontactmanager.c (Diff revision 3)

Sorry, I'm missing what adding this does?

grim Jan. 13, 2023, 5:11 a.m.

The contact manager watches the person property on purple_contact and then updates accordingly. I'm not super happy with this setup as it's not at all obvious, but having to manually add people to the contact manager seemed like overkill.

QuLogic Jan. 13, 2023, 5:26 a.m.

Ah okay, this whole function is temporary until PurpleBuddy is gone, right?

grim Jan. 13, 2023, 6:36 a.m.

Correct, the manager does the rest of this on it's own based on whether or not the contact has a person. Which what we're mimicing here.

Ship it!

```
Ship It!
```

Status:: Completed