Summary

Bump C standard to C99 for libpurple files and fix warnings

Review Request #2122 — Created Dec. 12, 2022 and submitted Dec. 12, 2022, 4:58 a.m.

Information

Owner

QuLogic

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Bump C standard to C99 for libpurple files and fix warnings

Testing Done

Touched all source files and compiled; saw no new warnings.

Commits

Summary	ID
Bump C standard to C99 for libpurple files and fix warnings	febe626249d01d0c43508522e2f0998483c119ea

Expand All
Collapse All

purple-history/purplehistorycore.c (Diff revision 1)

this works?!

QuLogic Dec. 12, 2022, 4:56 a.m.

Apparently yes, though gcc docs say after the parameters in a declaration. But for the definition (without declaration), it seems to work here or between return type and name. Hopefully fine on other compilers.

grim Dec. 12, 2022, 5:03 a.m.
```
We'll see with the build agents ;)
```

Ship it!

```
Ship It!
```

Awesome work, thank you so much for getting this done!!

Status:: Completed