Summary

Remove the icon from PurpleIMConversation

Review Request #2114 — Created Dec. 7, 2022 and submitted Dec. 14, 2022, 9:37 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

The intent is to move this functionality to PurpleConversation once PurpleAvatar
has laned, so this just moves the exist code out of the way.

Testing Done

Ran the tests and ran with demo and xmmp accounts. Avatars are busted in the info pane at the moment.

Commits

Summary	ID
Remove the icon from PurpleIMConversation The intent is to move this functionality to PurpleConversation once PurpleAvatar has laned, so this just moves the exist code out of the way.	1ef2145cd92b46906b1998fd8250eafbf90d399f

Issues

Description	From	Last Updated
This vfunc does nothing now?	QuLogic	Dec. 14, 2022, 8:40 a.m.

Change Summary:

rebased

Commits:

	Summary	ID
	Remove the icon from PurpleIMConversation The intent is to move this functionality to PurpleConversation once PurpleAvatar has laned, so this just moves the exist code out of the way.	6db07dcf4dd84c5f2e816dd588b13a2262bbb052
	Remove the icon from PurpleIMConversation The intent is to move this functionality to PurpleConversation once PurpleAvatar has laned, so this just moves the exist code out of the way.	6de6bbda05f39349a5671777abf5849a6acb3090

Diff:

	libpurple/buddyicon.c
	libpurple/purpleimconversation.h
	libpurple/purpleimconversation.c
	pidgin/pidginaddbuddydialog.c
	pidgin/pidginavatar.c

libpurple/purpleimconversation.c (Diff revision 2)

The issue has been resolved. Show all issues

This vfunc does nothing now?

Change Summary:

rebased and removed the now unused _constructed vfunc.

Commits:

	Summary	ID
	Remove the icon from PurpleIMConversation The intent is to move this functionality to PurpleConversation once PurpleAvatar has laned, so this just moves the exist code out of the way.	6de6bbda05f39349a5671777abf5849a6acb3090
	Remove the icon from PurpleIMConversation The intent is to move this functionality to PurpleConversation once PurpleAvatar has laned, so this just moves the exist code out of the way.	1ef2145cd92b46906b1998fd8250eafbf90d399f

Diff:

	libpurple/buddyicon.c
	libpurple/purpleimconversation.h
	libpurple/purpleimconversation.c
	pidgin/pidginaddbuddydialog.c
	pidgin/pidginavatar.c

Ship it!