Summary

Fix a compilation error on windows and many warnings

Review Request #2106 — Created Nov. 29, 2022 and submitted Dec. 1, 2022, 9:19 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

SIG_ACK is macro for handling signals on windows. We just want to use it as a
constant, so we #undef if we see it.

Mark a bunch of parameters as unused.

Fix a bunch of warnings about type casting function pointers.

Testing Done

Compiled and ran on windows.

Commits

Summary	ID
Fix a compilation error on windows and many warnings SIG_ACK is macro for handling signals on windows. We just want to use it as a constant, so we #undef if we see it. Mark a bunch of parameters as unused. Fix a bunch of warnings about type casting function pointers.	467f5027b92335c8f8faa8eecd0c3ae6a4f716d0

Issues

Description	From	Last Updated
Could fit these two lines together now?	QuLogic	Nov. 29, 2022, 10:18 a.m.
Ditto.	QuLogic	Nov. 29, 2022, 10:18 a.m.

pidgin/win32/winpidgin.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Could fit these two lines together now?
```
pidgin/win32/winpidgin.c (Diff revision 1)
The issue has been resolved. Show all issues
```
Ditto.
```

Change Summary:

fix some line wraps

Commits:

	Summary	ID
	Fix a compilation error on windows and many warnings SIG_ACK is macro for handling signals on windows. We just want to use it as a constant, so we #undef if we see it. Mark a bunch of parameters as unused. Fix a bunch of warnings about type casting function pointers.	2af97c39c405c75e1b5cf24f85d10a375963f84a
	Fix a compilation error on windows and many warnings SIG_ACK is macro for handling signals on windows. We just want to use it as a constant, so we #undef if we see it. Mark a bunch of parameters as unused. Fix a bunch of warnings about type casting function pointers.	467f5027b92335c8f8faa8eecd0c3ae6a4f716d0

Diff:

Revision 2 (+74 -34)

Show changes

	libpurple/protocols/ircv3/purpleircv3capabilities.c
	pidgin/meson.build
	pidgin/win32/gtkwin32dep.c
	pidgin/win32/winpidgin.c

Ship it!

```
Ship It!
```

Status:: Completed

pidgin/win32/winpidgin.c (Diff revision 1)

pidgin/win32/winpidgin.c (Diff revision 1)