Summary

Create PurpleAvatar to represent avatars

Review Request #2092 — Created Nov. 24, 2022 and submitted Dec. 13, 2022, 5:41 a.m.

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Groups

People

Description

Create PurpleAvatar to represent avatars

Testing Done

Ran the unit tests and manually verified the docs.

Commits

Summary	ID
Create PurpleAvatar to represent avatars	76e79f1b9f9877ef41d6957781d45563ef3b35a3

Issues

Description	From	Last Updated
I wonder if we should be using GFile?	QuLogic	Dec. 13, 2022, 3:15 a.m.
representation that is used	QuLogic	Nov. 28, 2022, 3:15 a.m.

The issue has been dropped. Show all issues

I wonder if we should be using GFile?

I had the same thought, but none of the GdkPixbuf.Pixbuf api takes a GFile so I left everything as a filename.

Although maybe GIcon would make more sense in general?

Commits:

	Summary	ID
	Create PurpleAvatar to represent avatars	7b6551ae9fd2dece4805650d9f2b664b13577e03
	Create PurpleAvatar to represent avatars	695f9e06a5568bf7432fa05d8db07bf9b3312f1f

Diff:

	libpurple/meson.build
	libpurple/purpleavatar.h
	libpurple/purpleavatar.c
	libpurple/tests/meson.build
	libpurple/tests/test_avatar.c
	po/POTFILES.in

Change Summary:

rebased

Commits:

	Summary	ID
	Create PurpleAvatar to represent avatars	695f9e06a5568bf7432fa05d8db07bf9b3312f1f
	Create PurpleAvatar to represent avatars	76e79f1b9f9877ef41d6957781d45563ef3b35a3

Diff:

	libpurple/meson.build
	libpurple/purpleavatar.h
	libpurple/purpleavatar.c
	libpurple/tests/meson.build
	libpurple/tests/test_avatar.c
	po/POTFILES.in

Ship it!

libpurple/purpleavatar.h (Diff revision 1)