Summary

Remove soupcompat.h since we require libsoup3 now

Review Request #2068 — Created Nov. 17, 2022 and submitted Nov. 17, 2022, 5:45 a.m.

Information

Owner

grim

Repository

pidgin/pidgin

Branch

default

Bugs

Depends On

Reviewers

Groups

pidgin

People

Description

Remove soupcompat.h since we require libsoup3 now

Testing Done

Compiled

Commits

Summary	ID
Remove soupcompat.h since we require libsoup3 now	688e9bf6ddd79ee0be0adf768ada18b6492eb0d0

Issues

Description	From	Last Updated
But we don't? There's still a soup2 option in Meson.	QuLogic	Nov. 17, 2022, 4:34 a.m.
This was technically for the 'if you support both' case, so maybe we don't need to keep it.	QuLogic	Nov. 17, 2022, 5:38 a.m.

The issue has been resolved. Show all issues

But we don't? There's still a soup2 option in Meson.

Change Summary:

remove soup2 meson options

Commits:

	Summary	ID
	Remove soupcompat.h since we require libsoup3 now	42f3e8fefb26649318a2703caac983fd51b7c5cb
	Remove soupcompat.h since we require libsoup3 now	d5b88582019684a653fcc29e8efc2442ade7686c

Diff:

Revision 2 (+12 -392)

Show changes

	meson.build
	meson_options.txt
	finch/plugins/gnttinyurl/gnttinyurl.c
	libpurple/soupcompat.h
	libpurple/protocols/facebook/api.c
	libpurple/protocols/facebook/data.c
	libpurple/protocols/facebook/http.c
	libpurple/protocols/gg/avatar.c
	6 more

meson.build (Diff revision 2)

The issue has been resolved. Show all issues

This was technically for the 'if you support both' case, so maybe we don't need to keep it.

Change Summary:

remove the soup_api_version variable

Commits:

	Summary	ID
	Remove soupcompat.h since we require libsoup3 now	d5b88582019684a653fcc29e8efc2442ade7686c
	Remove soupcompat.h since we require libsoup3 now	acd129b0c25c75c4d8eb7b42263b0e41942c4a71

Diff:

Revision 3 (+14 -396)

Show changes

	meson.build
	meson_options.txt
	finch/plugins/gnttinyurl/gnttinyurl.c
	libpurple/meson.build
	libpurple/soupcompat.h
	libpurple/protocols/facebook/api.c
	libpurple/protocols/facebook/data.c
	libpurple/protocols/facebook/http.c
	8 more

Change Summary:

rebased

Commits:

	Summary	ID
	Remove soupcompat.h since we require libsoup3 now	acd129b0c25c75c4d8eb7b42263b0e41942c4a71
	Remove soupcompat.h since we require libsoup3 now	688e9bf6ddd79ee0be0adf768ada18b6492eb0d0

Diff:

Revision 4 (+14 -396)

Show changes

	meson.build
	meson_options.txt
	finch/plugins/gnttinyurl/gnttinyurl.c
	libpurple/meson.build
	libpurple/soupcompat.h
	libpurple/protocols/facebook/api.c
	libpurple/protocols/facebook/data.c
	libpurple/protocols/facebook/http.c
	8 more

Ship it!

```
Ship It!
```

Status:: Completed